Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: chrome/browser/ui/views/session_crashed_bubble_view.cc

Issue 373623002: Convert remaining WebContentsObservers loading callbacks to use RFH. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix CrOS test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/session_crashed_bubble_view.h" 5 #include "chrome/browser/ui/views/session_crashed_bubble_view.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 false)); 336 false));
337 } 337 }
338 338
339 void SessionCrashedBubbleView::DidStartNavigationToPendingEntry( 339 void SessionCrashedBubbleView::DidStartNavigationToPendingEntry(
340 const GURL& url, 340 const GURL& url,
341 content::NavigationController::ReloadType reload_type) { 341 content::NavigationController::ReloadType reload_type) {
342 started_navigation_ = true; 342 started_navigation_ = true;
343 } 343 }
344 344
345 void SessionCrashedBubbleView::DidFinishLoad( 345 void SessionCrashedBubbleView::DidFinishLoad(
346 int64 frame_id, 346 content::RenderFrameHost* render_frame_host,
347 const GURL& validated_url, 347 const GURL& validated_url) {
348 bool is_main_frame,
349 content::RenderViewHost* render_view_host) {
350 if (started_navigation_) 348 if (started_navigation_)
351 CloseBubble(); 349 CloseBubble();
352 } 350 }
353 351
354 void SessionCrashedBubbleView::WasShown() { 352 void SessionCrashedBubbleView::WasShown() {
355 GetWidget()->Show(); 353 GetWidget()->Show();
356 } 354 }
357 355
358 void SessionCrashedBubbleView::WasHidden() { 356 void SessionCrashedBubbleView::WasHidden() {
359 GetWidget()->Hide(); 357 GetWidget()->Hide();
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 GetWidget()->Close(); 390 GetWidget()->Close();
393 } 391 }
394 392
395 bool ShowSessionCrashedBubble(Browser* browser) { 393 bool ShowSessionCrashedBubble(Browser* browser) {
396 if (IsBubbleUIEnabled()) { 394 if (IsBubbleUIEnabled()) {
397 SessionCrashedBubbleView::Show(browser); 395 SessionCrashedBubbleView::Show(browser);
398 return true; 396 return true;
399 } 397 }
400 return false; 398 return false;
401 } 399 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698