Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: Source/bindings/core/v8/Dictionary.h

Issue 373613004: [ServiceWorker] Make Response class better conformance with the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated falken's comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/http/tests/serviceworker/resources/response-worker.js ('k') | Source/bindings/core/v8/Dictionary.cpp » ('j') | Source/modules/serviceworkers/FetchResponseData.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 #include <v8.h> 42 #include <v8.h>
43 43
44 namespace WebCore { 44 namespace WebCore {
45 45
46 class ArrayValue; 46 class ArrayValue;
47 class DOMError; 47 class DOMError;
48 class Element; 48 class Element;
49 class LocalDOMWindow; 49 class LocalDOMWindow;
50 class Gamepad; 50 class Gamepad;
51 class MediaStream; 51 class MediaStream;
52 class HeaderMap;
53 class Headers; 52 class Headers;
54 class IDBKeyRange; 53 class IDBKeyRange;
55 class MIDIPort; 54 class MIDIPort;
56 class MediaKeyError; 55 class MediaKeyError;
57 class Notification; 56 class Notification;
58 class Path2D; 57 class Path2D;
59 class SpeechRecognitionResult; 58 class SpeechRecognitionResult;
60 class SpeechRecognitionResultList; 59 class SpeechRecognitionResultList;
61 class Storage; 60 class Storage;
62 class TrackBase; 61 class TrackBase;
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 bool get(const String&, Member<SpeechRecognitionResultList>&) const; 97 bool get(const String&, Member<SpeechRecognitionResultList>&) const;
99 bool get(const String&, Member<Gamepad>&) const; 98 bool get(const String&, Member<Gamepad>&) const;
100 bool get(const String&, Member<MediaStream>&) const; 99 bool get(const String&, Member<MediaStream>&) const;
101 bool get(const String&, RefPtrWillBeMember<EventTarget>&) const; 100 bool get(const String&, RefPtrWillBeMember<EventTarget>&) const;
102 bool get(const String&, HashSet<AtomicString>&) const; 101 bool get(const String&, HashSet<AtomicString>&) const;
103 bool get(const String&, Dictionary&) const; 102 bool get(const String&, Dictionary&) const;
104 bool get(const String&, Vector<String>&) const; 103 bool get(const String&, Vector<String>&) const;
105 bool get(const String&, ArrayValue&) const; 104 bool get(const String&, ArrayValue&) const;
106 bool get(const String&, RefPtrWillBeMember<DOMError>&) const; 105 bool get(const String&, RefPtrWillBeMember<DOMError>&) const;
107 bool get(const String&, v8::Local<v8::Value>&) const; 106 bool get(const String&, v8::Local<v8::Value>&) const;
108 bool get(const String&, RefPtr<HeaderMap>&) const;
109 bool get(const String&, RefPtr<Headers>&) const; 107 bool get(const String&, RefPtr<Headers>&) const;
110 108
111 class ConversionContext { 109 class ConversionContext {
112 public: 110 public:
113 ConversionContext(const String& interfaceName, const String& methodName, ExceptionState& exceptionState) 111 ConversionContext(const String& interfaceName, const String& methodName, ExceptionState& exceptionState)
114 : m_interfaceName(interfaceName) 112 : m_interfaceName(interfaceName)
115 , m_methodName(methodName) 113 , m_methodName(methodName)
116 , m_exceptionState(exceptionState) 114 , m_exceptionState(exceptionState)
117 , m_dirty(true) 115 , m_dirty(true)
118 { 116 {
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 if (context.isNullable() && WebCore::isUndefinedOrNull(v8Value)) 344 if (context.isNullable() && WebCore::isUndefinedOrNull(v8Value))
347 return true; 345 return true;
348 346
349 context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does n ot have a " + context.typeName() + " type.")); 347 context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does n ot have a " + context.typeName() + " type."));
350 return false; 348 return false;
351 } 349 }
352 350
353 } 351 }
354 352
355 #endif // Dictionary_h 353 #endif // Dictionary_h
OLDNEW
« no previous file with comments | « LayoutTests/http/tests/serviceworker/resources/response-worker.js ('k') | Source/bindings/core/v8/Dictionary.cpp » ('j') | Source/modules/serviceworkers/FetchResponseData.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698