Refactor to convert vector to scoped_ptr in ZoomController.

Refactor to convert vector to scoped_ptr in ZoomController.

A scoped_ptr has less overhead than a vector. This CL refactors to
store ZoomChangedEventData structs via a scoped_ptr since there will
be (at most) one of these at a time.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281726

[wjmaclean, 2014-07-07 18:35:29]

I decided to go the scoped_ptr approach. Please take a look?

[Dan Beam, 2014-07-07 18:45:15]

lgtm

[Dan Beam, 2014-07-07 18:46:00]

https://codereview.chromium.org/373603007/diff/1/chrome/browser/ui/zoom/zoom_...
File chrome/browser/ui/zoom/zoom_controller.h (right):

https://codereview.chromium.org/373603007/diff/1/chrome/browser/ui/zoom/zoom_...
chrome/browser/ui/zoom/zoom_controller.h:8: #include <vector>
^ remove

https://codereview.chromium.org/373603007/diff/1/chrome/browser/ui/zoom/zoom_...
chrome/browser/ui/zoom/zoom_controller.h:11: #include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"

[wjmaclean, 2014-07-07 19:01:28]

Thanks!

https://codereview.chromium.org/373603007/diff/1/chrome/browser/ui/zoom/zoom_...
File chrome/browser/ui/zoom/zoom_controller.h (right):

https://codereview.chromium.org/373603007/diff/1/chrome/browser/ui/zoom/zoom_...
chrome/browser/ui/zoom/zoom_controller.h:8: #include <vector>
On 2014/07/07 18:45:59, Dan Beam wrote:
> ^ remove

Done.

Thanks for spotting, I missed this (again! :-( ).

https://codereview.chromium.org/373603007/diff/1/chrome/browser/ui/zoom/zoom_...
chrome/browser/ui/zoom/zoom_controller.h:11: #include "base/compiler_specific.h"
On 2014/07/07 18:45:59, Dan Beam wrote:
> #include "base/memory/scoped_ptr.h"

Done.

[wjmaclean, 2014-07-07 19:01:49]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2014-07-07 19:02:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/373603007/20001

[commit-bot: I haz the power, 2014-07-07 22:57:01]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-07-07 23:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-07 23:22:28]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)

[wjmaclean, 2014-07-08 11:22:23]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2014-07-08 11:24:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/373603007/20001

[commit-bot: I haz the power, 2014-07-08 12:07:44]

Change committed as 281726