Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 373603004: Hashless hex color quirk for color/background/border only. (Closed)

Created:
6 years, 5 months ago by rune
Modified:
6 years, 4 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Hashless hex color quirk for color/background/border only. According to the quirks mode spec[1], the hashless hex color quirk only applies to a few properties including color, background-color (not from short-hand), and various border-color properties. This aligns the Blink implementation with Gecko and the spec. The duplicated code and early break is there to avoid regressions in blink performance tests (there were cases in the CSS and SVG directories that detected regressions locally). [1] http://quirks.spec.whatwg.org/#the-hashless-hex-color-quirk BUG=391343 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179524

Patch Set 1 #

Patch Set 2 : Use param instead of parser state #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -12 lines) Patch
A LayoutTests/fast/css/parsing-color-quirk.html View 1 2 1 chunk +136 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 2 chunks +33 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rune
6 years, 5 months ago (2014-07-07 17:48:35 UTC) #1
Timothy Loh
On 2014/07/07 17:48:35, rune (vacation) wrote: I think this would be simpler if we added ...
6 years, 5 months ago (2014-07-15 04:13:42 UTC) #2
rune
On 2014/07/15 04:13:42, Timothy Loh wrote: > On 2014/07/07 17:48:35, rune (vacation) wrote: > > ...
6 years, 4 months ago (2014-08-04 23:14:35 UTC) #3
Timothy Loh
On 2014/08/04 23:14:35, rune wrote: > On 2014/07/15 04:13:42, Timothy Loh wrote: > > On ...
6 years, 4 months ago (2014-08-05 07:35:42 UTC) #4
rune
The CQ bit was checked by rune@opera.com
6 years, 4 months ago (2014-08-05 07:42:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/373603004/20001
6 years, 4 months ago (2014-08-05 07:46:03 UTC) #6
rune
The CQ bit was checked by rune@opera.com
6 years, 4 months ago (2014-08-05 11:01:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/373603004/40001
6 years, 4 months ago (2014-08-05 11:02:33 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 16:46:49 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 21:04:37 UTC) #10
Message was sent while issue was closed.
Change committed as 179524

Powered by Google App Engine
This is Rietveld 408576698