content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java - Issue 373523002: Send correct key-codes when doing composition events instead of always 0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

Issue 373523002: Send correct key-codes when doing composition events instead of always 0. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added some todo comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

index de9f9cce77fdea84ce6f403d65421ea9443a6b78..36b80513cdbb493fac73603d6a9f1ad3645a2087 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

@@ -460,7 +460,12 @@ public class AdapterInputConnection extends BaseInputConnection {

super.setComposingRegion(a, b);

}

updateSelectionIfRequired();

- return mImeAdapter.setComposingRegion(a, b);

+ CharSequence regionText = null;

+ if (b > a) {

+ regionText = mEditable.subSequence(start, end);

+ }

+ return mImeAdapter.setComposingRegion(regionText, a, b);

}

boolean isActive() {

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('j') | no next file with comments »