Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 373463004: Cleanup: favicon: Remove some chrome/ includes from favicon_handler. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
blundell
CC:
chromium-reviews, browser-components-watch_chromium.org, jfi_chromium.org, sdefresne
Project:
chromium
Visibility:
Public.

Description

Cleanup: favicon: Remove some chrome/ includes from favicon_handler. BUG=359514 TEST=None R=blundell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282819

Patch Set 1 #

Patch Set 2 : REBASE + unit_tests fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/favicon/favicon_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/favicon/favicon_handler.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/favicon/favicon_handler_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
6 years, 5 months ago (2014-07-04 16:08:49 UTC) #1
blundell
LGTM
6 years, 5 months ago (2014-07-07 14:10:02 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-12 08:15:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/373463004/20001
6 years, 5 months ago (2014-07-12 08:15:47 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 12:53:40 UTC) #5
Message was sent while issue was closed.
Change committed as 282819

Powered by Google App Engine
This is Rietveld 408576698