Issue 373463004: Cleanup: favicon: Remove some chrome/ includes from favicon_handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 373463004: Cleanup: favicon: Remove some chrome/ includes from favicon_handler. (Closed)

Created:
6 years, 5 months ago by tfarina

Modified:
6 years, 5 months ago

Reviewers:
blundell

CC:
chromium-reviews, browser-components-watch_chromium.org, jfi_chromium.org, sdefresne

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Cleanup: favicon: Remove some chrome/ includes from favicon_handler. BUG=359514 TEST=None R=blundell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282819

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
M	chrome/browser/favicon/favicon_handler.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/favicon/favicon_handler.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/favicon/favicon_handler_unittest.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/373463004/20001

6 years, 5 months ago (2014-07-12 08:15:47 UTC) #4

Message was sent while issue was closed.

Change committed as 282819