Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 373443002: Remove all uses of "using namespace std" (Closed)

Created:
6 years, 5 months ago by Abhishek
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove all uses of "using namespace std" BUG=331299 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282614

Patch Set 1 #

Patch Set 2 : adding myself in AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -41 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/MockColorChooser.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/MockSpellCheck.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/MockWebSpeechRecognizer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/SpellCheckClient.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/TestCommon.cpp View 1 chunk +6 lines, -8 lines 0 comments Download
M content/shell/renderer/test_runner/TestInterfaces.cpp View 4 chunks +13 lines, -14 lines 0 comments Download
M content/shell/renderer/test_runner/TestPlugin.cpp View 4 chunks +4 lines, -5 lines 0 comments Download
M content/shell/renderer/test_runner/WebTask.cpp View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Abhishek
PTAL!
6 years, 5 months ago (2014-07-04 08:37:43 UTC) #1
Abhishek
On 2014/07/04 08:37:43, Abhishek wrote: > PTAL! Dear Dirk Pranke: Could you please have a ...
6 years, 5 months ago (2014-07-10 13:17:36 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-10 13:18:09 UTC) #3
Abhishek
The CQ bit was checked by abhishek.a21@samsung.com
6 years, 5 months ago (2014-07-10 13:23:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/373443002/1
6 years, 5 months ago (2014-07-10 13:24:41 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 15:04:04 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 15:07:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79119)
6 years, 5 months ago (2014-07-10 15:07:11 UTC) #8
Abhishek
The CQ bit was checked by abhishek.a21@samsung.com
6 years, 5 months ago (2014-07-10 16:48:57 UTC) #9
Abhishek
The CQ bit was unchecked by abhishek.a21@samsung.com
6 years, 5 months ago (2014-07-10 16:49:01 UTC) #10
Abhishek
The CQ bit was checked by abhishek.a21@samsung.com
6 years, 5 months ago (2014-07-10 17:07:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/373443002/1
6 years, 5 months ago (2014-07-10 17:08:15 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 17:12:06 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 17:16:26 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79164)
6 years, 5 months ago (2014-07-10 17:16:27 UTC) #15
Abhishek
The CQ bit was checked by abhishek.a21@samsung.com
6 years, 5 months ago (2014-07-11 09:45:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/373443002/20001
6 years, 5 months ago (2014-07-11 09:45:50 UTC) #17
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 11:27:35 UTC) #18
Message was sent while issue was closed. 
Change committed as 282614

Powered by Google App Engine
This is Rietveld 408576698