Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 373423004: win/clang: Don't token-paste ( onto function name. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

win/clang: Don't token-paste ( onto function name. Fixes ..\..\win8\metro_driver\winrt_utils.cc(80,1) : error(clang): pasting formed 'CreateString(', an invalid preprocessing token [-Winvalid-token-paste] IMPLEMENT_CREATE_PROPERTY(String, HSTRING); ^ ..\..\win8\metro_driver\winrt_utils.cc(54,47) : note(clang): expanded from macro 'IMPLEMENT_CREATE_PROPERTY' hr = property_value_statics->Create ## Name ## ( \ ^ BUG=82385 TBR=grt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M win8/metro_driver/winrt_utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 5 months ago (2014-07-12 19:24:49 UTC) #1
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-12 23:07:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/373423004/1
6 years, 5 months ago (2014-07-12 23:07:29 UTC) #3
commit-bot: I haz the power
Change committed as 282853
6 years, 5 months ago (2014-07-13 01:04:15 UTC) #4
grt (UTC plus 2)
6 years, 5 months ago (2014-07-14 03:11:23 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698