Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5943)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/wtf/ListHashSet.h

Issue 373423003: Save 100-300 KB footprint by not force inlining HashTable functions Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Non-inlined HashTable: Rebased to newer origin/master Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/wtf/HashTable.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/wtf/ListHashSet.h
diff --git a/Source/wtf/ListHashSet.h b/Source/wtf/ListHashSet.h
index 52b2906becfdcfe3026b9ffbaab3ba5ee5f68678..92edcf034204eaaea069aca58535a533a3335552 100644
--- a/Source/wtf/ListHashSet.h
+++ b/Source/wtf/ListHashSet.h
@@ -659,14 +659,14 @@ namespace WTF {
};
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline ListHashSet<T, inlineCapacity, U, V>::ListHashSet()
+ ListHashSet<T, inlineCapacity, U, V>::ListHashSet()
: m_head(0)
, m_tail(0)
{
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline ListHashSet<T, inlineCapacity, U, V>::ListHashSet(const ListHashSet& other)
+ ListHashSet<T, inlineCapacity, U, V>::ListHashSet(const ListHashSet& other)
: m_head(0)
, m_tail(0)
{
@@ -676,7 +676,7 @@ namespace WTF {
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline ListHashSet<T, inlineCapacity, U, V>& ListHashSet<T, inlineCapacity, U, V>::operator=(const ListHashSet& other)
+ ListHashSet<T, inlineCapacity, U, V>& ListHashSet<T, inlineCapacity, U, V>::operator=(const ListHashSet& other)
{
ListHashSet tmp(other);
swap(tmp);
@@ -684,7 +684,7 @@ namespace WTF {
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline void ListHashSet<T, inlineCapacity, U, V>::swap(ListHashSet& other)
+ void ListHashSet<T, inlineCapacity, U, V>::swap(ListHashSet& other)
{
m_impl.swap(other.m_impl);
std::swap(m_head, other.m_head);
@@ -693,21 +693,21 @@ namespace WTF {
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline void ListHashSet<T, inlineCapacity, U, V>::finalize()
+ void ListHashSet<T, inlineCapacity, U, V>::finalize()
{
COMPILE_ASSERT(!Allocator::isGarbageCollected, FinalizeOnHeapAllocatedListHashSetShouldNeverBeCalled);
deleteAllNodes();
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline T& ListHashSet<T, inlineCapacity, U, V>::first()
+ T& ListHashSet<T, inlineCapacity, U, V>::first()
{
ASSERT(!isEmpty());
return m_head->m_value;
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline void ListHashSet<T, inlineCapacity, U, V>::removeFirst()
+ void ListHashSet<T, inlineCapacity, U, V>::removeFirst()
{
ASSERT(!isEmpty());
m_impl.remove(m_head);
@@ -715,28 +715,28 @@ namespace WTF {
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline const T& ListHashSet<T, inlineCapacity, U, V>::first() const
+ const T& ListHashSet<T, inlineCapacity, U, V>::first() const
{
ASSERT(!isEmpty());
return m_head->m_value;
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline T& ListHashSet<T, inlineCapacity, U, V>::last()
+ T& ListHashSet<T, inlineCapacity, U, V>::last()
{
ASSERT(!isEmpty());
return m_tail->m_value;
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline const T& ListHashSet<T, inlineCapacity, U, V>::last() const
+ const T& ListHashSet<T, inlineCapacity, U, V>::last() const
{
ASSERT(!isEmpty());
return m_tail->m_value;
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline void ListHashSet<T, inlineCapacity, U, V>::removeLast()
+ void ListHashSet<T, inlineCapacity, U, V>::removeLast()
{
ASSERT(!isEmpty());
m_impl.remove(m_tail);
@@ -744,7 +744,7 @@ namespace WTF {
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline typename ListHashSet<T, inlineCapacity, U, V>::iterator ListHashSet<T, inlineCapacity, U, V>::find(ValuePeekInType value)
+ typename ListHashSet<T, inlineCapacity, U, V>::iterator ListHashSet<T, inlineCapacity, U, V>::find(ValuePeekInType value)
{
ImplTypeIterator it = m_impl.template find<BaseTranslator>(value);
if (it == m_impl.end())
@@ -753,7 +753,7 @@ namespace WTF {
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline typename ListHashSet<T, inlineCapacity, U, V>::const_iterator ListHashSet<T, inlineCapacity, U, V>::find(ValuePeekInType value) const
+ typename ListHashSet<T, inlineCapacity, U, V>::const_iterator ListHashSet<T, inlineCapacity, U, V>::find(ValuePeekInType value) const
{
ImplTypeConstIterator it = m_impl.template find<BaseTranslator>(value);
if (it == m_impl.end())
@@ -769,7 +769,7 @@ namespace WTF {
template<typename ValueType, size_t inlineCapacity, typename U, typename V>
template<typename HashTranslator, typename T>
- inline typename ListHashSet<ValueType, inlineCapacity, U, V>::iterator ListHashSet<ValueType, inlineCapacity, U, V>::find(const T& value)
+ typename ListHashSet<ValueType, inlineCapacity, U, V>::iterator ListHashSet<ValueType, inlineCapacity, U, V>::find(const T& value)
{
ImplTypeConstIterator it = m_impl.template find<ListHashSetTranslatorAdapter<HashTranslator> >(value);
if (it == m_impl.end())
@@ -779,7 +779,7 @@ namespace WTF {
template<typename ValueType, size_t inlineCapacity, typename U, typename V>
template<typename HashTranslator, typename T>
- inline typename ListHashSet<ValueType, inlineCapacity, U, V>::const_iterator ListHashSet<ValueType, inlineCapacity, U, V>::find(const T& value) const
+ typename ListHashSet<ValueType, inlineCapacity, U, V>::const_iterator ListHashSet<ValueType, inlineCapacity, U, V>::find(const T& value) const
{
ImplTypeConstIterator it = m_impl.template find<ListHashSetTranslatorAdapter<HashTranslator> >(value);
if (it == m_impl.end())
@@ -789,13 +789,13 @@ namespace WTF {
template<typename ValueType, size_t inlineCapacity, typename U, typename V>
template<typename HashTranslator, typename T>
- inline bool ListHashSet<ValueType, inlineCapacity, U, V>::contains(const T& value) const
+ bool ListHashSet<ValueType, inlineCapacity, U, V>::contains(const T& value) const
{
return m_impl.template contains<ListHashSetTranslatorAdapter<HashTranslator> >(value);
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline bool ListHashSet<T, inlineCapacity, U, V>::contains(ValuePeekInType value) const
+ bool ListHashSet<T, inlineCapacity, U, V>::contains(ValuePeekInType value) const
{
return m_impl.template contains<BaseTranslator>(value);
}
@@ -862,7 +862,7 @@ namespace WTF {
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline void ListHashSet<T, inlineCapacity, U, V>::remove(iterator it)
+ void ListHashSet<T, inlineCapacity, U, V>::remove(iterator it)
{
if (it == end())
return;
@@ -871,7 +871,7 @@ namespace WTF {
}
template<typename T, size_t inlineCapacity, typename U, typename V>
- inline void ListHashSet<T, inlineCapacity, U, V>::clear()
+ void ListHashSet<T, inlineCapacity, U, V>::clear()
{
deleteAllNodes();
m_impl.clear();
« no previous file with comments | « Source/wtf/HashTable.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698