Source/core/page/EventSource.cpp - Issue 373423002: Split Dictionary's get and convert into DictionaryHelper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventSource.cpp

Issue 373423002: Split Dictionary's get and convert into DictionaryHelper. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/DictionaryHelperForCore.cpp ('K') | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/modules/crypto/NormalizeAlgorithm.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/EventSource.cpp

diff --git a/Source/core/page/EventSource.cpp b/Source/core/page/EventSource.cpp

index f63cc4a3b5b5e1eba2824440cd2195424cd3c253..7ba778cf6837f06b80e84fb680a1b6e072e723dc 100644

--- a/Source/core/page/EventSource.cpp

+++ b/Source/core/page/EventSource.cpp

@@ -34,6 +34,7 @@

#include "core/page/EventSource.h"

#include "bindings/core/v8/Dictionary.h"

+#include "bindings/core/v8/DictionaryHelper.h"

#include "bindings/core/v8/ExceptionState.h"

#include "bindings/core/v8/ScriptController.h"

#include "bindings/core/v8/SerializedScriptValue.h"

@@ -69,7 +70,7 @@ inline EventSource::EventSource(ExecutionContext* context, const KURL& url, cons

, m_reconnectDelay(defaultReconnectDelay)

{

ScriptWrappable::init(this);

- eventSourceInit.get("withCredentials", m_withCredentials);

+ DictionaryHelper::get(eventSourceInit, "withCredentials", m_withCredentials);

}

PassRefPtrWillBeRawPtr<EventSource> EventSource::create(ExecutionContext* context, const String& url, const Dictionary& eventSourceInit, ExceptionState& exceptionState)

« Source/bindings/core/v8/DictionaryHelperForCore.cpp ('K') | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/modules/crypto/NormalizeAlgorithm.cpp » ('j') | no next file with comments »