Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: Source/core/animation/TimingInput.cpp

Issue 373423002: Split Dictionary's get and convert into DictionaryHelper. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/TimingInput.cpp
diff --git a/Source/core/animation/TimingInput.cpp b/Source/core/animation/TimingInput.cpp
index bd187b9bc9c3de80fb3b40b90c8958ed2d08e453..51f579a8e3903356fde2d4b8b470345a1dfc3b50 100644
--- a/Source/core/animation/TimingInput.cpp
+++ b/Source/core/animation/TimingInput.cpp
@@ -6,6 +6,7 @@
#include "core/animation/TimingInput.h"
#include "bindings/core/v8/Dictionary.h"
+#include "bindings/core/v8/DictionaryHelper.h"
#include "core/css/parser/BisonCSSParser.h"
#include "core/css/resolver/CSSToStyleMap.h"
@@ -103,40 +104,40 @@ Timing TimingInput::convert(const Dictionary& timingInputDictionary)
// null, NaN, Infinity values better.
// See: http://www.w3.org/TR/WebIDL/#es-double
double startDelay = Timing::defaults().startDelay;
- timingInputDictionary.get("delay", startDelay);
+ DictionaryHelper::get(timingInputDictionary, "delay", startDelay);
setStartDelay(result, startDelay);
double endDelay = Timing::defaults().endDelay;
- timingInputDictionary.get("endDelay", endDelay);
+ DictionaryHelper::get(timingInputDictionary, "endDelay", endDelay);
setEndDelay(result, endDelay);
String fillMode;
- timingInputDictionary.get("fill", fillMode);
+ DictionaryHelper::get(timingInputDictionary, "fill", fillMode);
setFillMode(result, fillMode);
double iterationStart = Timing::defaults().iterationStart;
- timingInputDictionary.get("iterationStart", iterationStart);
+ DictionaryHelper::get(timingInputDictionary, "iterationStart", iterationStart);
setIterationStart(result, iterationStart);
double iterationCount = Timing::defaults().iterationCount;
- timingInputDictionary.get("iterations", iterationCount);
+ DictionaryHelper::get(timingInputDictionary, "iterations", iterationCount);
setIterationCount(result, iterationCount);
double iterationDuration = 0;
- if (timingInputDictionary.get("duration", iterationDuration)) {
+ if (DictionaryHelper::get(timingInputDictionary, "duration", iterationDuration)) {
setIterationDuration(result, iterationDuration);
}
double playbackRate = Timing::defaults().playbackRate;
- timingInputDictionary.get("playbackRate", playbackRate);
+ DictionaryHelper::get(timingInputDictionary, "playbackRate", playbackRate);
setPlaybackRate(result, playbackRate);
String direction;
- timingInputDictionary.get("direction", direction);
+ DictionaryHelper::get(timingInputDictionary, "direction", direction);
setPlaybackDirection(result, direction);
String timingFunctionString;
- timingInputDictionary.get("easing", timingFunctionString);
+ DictionaryHelper::get(timingInputDictionary, "easing", timingFunctionString);
setTimingFunction(result, timingFunctionString);
result.assertValid();

Powered by Google App Engine
This is Rietveld 408576698