Source/modules/encoding/TextEncoder.cpp - Issue 373423002: Split Dictionary's get and convert into DictionaryHelper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/encoding/TextEncoder.cpp

Issue 373423002: Split Dictionary's get and convert into DictionaryHelper. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed LICENSE and windows build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/encoding/TextEncoder.cpp

diff --git a/Source/modules/encoding/TextEncoder.cpp b/Source/modules/encoding/TextEncoder.cpp

index 723f7666db87e7b17b1eb913ddfef419c3741495..d44de6c58c1c840678a3ab394b0ffea89fec7ce6 100644

--- a/Source/modules/encoding/TextEncoder.cpp

+++ b/Source/modules/encoding/TextEncoder.cpp

@@ -33,6 +33,7 @@

#include "modules/encoding/TextEncoder.h"

#include "bindings/core/v8/Dictionary.h"

+#include "bindings/core/v8/DictionaryHelper.h"

#include "bindings/core/v8/ExceptionState.h"

#include "wtf/text/CString.h"

#include "wtf/text/TextEncodingRegistry.h"

@@ -76,7 +77,7 @@ String TextEncoder::encoding() const

PassRefPtr<Uint8Array> TextEncoder::encode(const String& input, const Dictionary& options)

{

bool stream = false;

- options.get("stream", stream);

+ DictionaryHelper::get(options, "stream", stream);

// FIXME: Not flushing is not supported by TextCodec for encode; add it or

// handle split surrogates here.