Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: Source/bindings/core/v8/DictionaryHelperForBindings.h

Issue 373423002: Split Dictionary's get and convert into DictionaryHelper. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/Dictionary.cpp ('k') | Source/bindings/core/v8/DictionaryHelperForCore.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/DictionaryHelperForBindings.h
diff --git a/Source/bindings/core/v8/DictionaryHelperForBindings.h b/Source/bindings/core/v8/DictionaryHelperForBindings.h
new file mode 100644
index 0000000000000000000000000000000000000000..049f6fb70dab3969ea64fd1e83a2af838a1b56ce
--- /dev/null
+++ b/Source/bindings/core/v8/DictionaryHelperForBindings.h
@@ -0,0 +1,70 @@
+/*
+ * Copyright (C) 2010 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef DictionaryHelperForBindings_h
+#define DictionaryHelperForBindings_h
+
+#include "Source/bindings/core/v8/Dictionary.h"
+
+namespace WebCore {
+
+template <typename T>
+struct DictionaryHelperTraits {
+};
+
+template <template <typename> class PointerType, typename T>
+bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, PointerType<T>& value)
+{
+ v8::Local<v8::Value> v8Value;
+ if (!dictionary.get(key, v8Value))
+ return false;
+
+ value = DictionaryHelperTraits<T>::type::toNativeWithTypeCheck(dictionary.isolate(), v8Value);
+ return true;
+}
+
+template <template <typename> class PointerType, typename T>
+bool DictionaryHelper::convert(const Dictionary& dictionary, Dictionary::ConversionContext& context, const String& key, PointerType<T>& value)
+{
+ Dictionary::ConversionContextScope scope(context);
+
+ if (!DictionaryHelper::get(dictionary, key, value))
+ return true;
+
+ if (value)
+ return true;
+
+ v8::Local<v8::Value> v8Value;
+ dictionary.get(key, v8Value);
+ if (context.isNullable() && WebCore::isUndefinedOrNull(v8Value))
+ return true;
+
+ context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does not have a " + context.typeName() + " type."));
+ return false;
+}
+
+} // namespace WebCore
+
+#endif // DictionaryHelperForBindings_h
« no previous file with comments | « Source/bindings/core/v8/Dictionary.cpp ('k') | Source/bindings/core/v8/DictionaryHelperForCore.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698