Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: Source/bindings/core/v8/CustomElementConstructorBuilder.cpp

Issue 373423002: Split Dictionary's get and convert into DictionaryHelper. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/Dictionary.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
diff --git a/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp b/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
index 06bedc504815e6ecf339421574cfa0525f1f0640..5b73be1c9696a8ba2c6e0c723787af72aea2cf4b 100644
--- a/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
+++ b/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
@@ -74,7 +74,7 @@ bool CustomElementConstructorBuilder::validateOptions(const AtomicString& type,
v8::TryCatch tryCatch;
ScriptValue prototypeScriptValue;
- if (m_options->get("prototype", prototypeScriptValue) && !prototypeScriptValue.isNull()) {
+ if (DictionaryHelper::get(*m_options, "prototype", prototypeScriptValue) && !prototypeScriptValue.isNull()) {
ASSERT(!tryCatch.HasCaught());
if (!prototypeScriptValue.isObject()) {
CustomElementException::throwException(CustomElementException::PrototypeNotAnObject, type, exceptionState);
@@ -95,7 +95,7 @@ bool CustomElementConstructorBuilder::validateOptions(const AtomicString& type,
}
AtomicString extends;
- bool extendsProvidedAndNonNull = m_options->get("extends", extends);
+ bool extendsProvidedAndNonNull = DictionaryHelper::get(*m_options, "extends", extends);
if (tryCatch.HasCaught()) {
tryCatch.ReThrow();
« no previous file with comments | « no previous file | Source/bindings/core/v8/Dictionary.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698