Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: Source/modules/geolocation/PositionOptions.cpp

Issue 373423002: Split Dictionary's get and convert into DictionaryHelper. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/geolocation/PositionOptions.h" 6 #include "modules/geolocation/PositionOptions.h"
7 7
8 #include "bindings/core/v8/Dictionary.h" 8 #include "bindings/core/v8/Dictionary.h"
9 #include "bindings/core/v8/DictionaryHelper.h"
9 #include <limits.h> 10 #include <limits.h>
10 11
11 namespace WebCore { 12 namespace WebCore {
12 13
13 PositionOptions* PositionOptions::create(const Dictionary& options) 14 PositionOptions* PositionOptions::create(const Dictionary& options)
14 { 15 {
15 return new PositionOptions(options); 16 return new PositionOptions(options);
16 } 17 }
17 18
18 PositionOptions::PositionOptions(const Dictionary& options) 19 PositionOptions::PositionOptions(const Dictionary& options)
19 : m_highAccuracy(false) 20 : m_highAccuracy(false)
20 , m_maximumAge(0) 21 , m_maximumAge(0)
21 , m_timeout(std::numeric_limits<unsigned>::max()) 22 , m_timeout(std::numeric_limits<unsigned>::max())
22 { 23 {
23 if (options.hasProperty("enableHighAccuracy")) { 24 if (options.hasProperty("enableHighAccuracy")) {
24 bool highAccuracy; 25 bool highAccuracy;
25 if (options.get("enableHighAccuracy", highAccuracy)) 26 if (DictionaryHelper::get(options, "enableHighAccuracy", highAccuracy))
26 m_highAccuracy = highAccuracy; 27 m_highAccuracy = highAccuracy;
27 } 28 }
28 if (options.hasProperty("maximumAge")) { 29 if (options.hasProperty("maximumAge")) {
29 double maximumAge; 30 double maximumAge;
30 if (options.get("maximumAge", maximumAge)) { 31 if (DictionaryHelper::get(options, "maximumAge", maximumAge)) {
31 if (maximumAge < 0) 32 if (maximumAge < 0)
32 m_maximumAge = 0; 33 m_maximumAge = 0;
33 else if (maximumAge > std::numeric_limits<unsigned>::max()) 34 else if (maximumAge > std::numeric_limits<unsigned>::max())
34 m_maximumAge = std::numeric_limits<unsigned>::max(); 35 m_maximumAge = std::numeric_limits<unsigned>::max();
35 else 36 else
36 m_maximumAge = maximumAge; 37 m_maximumAge = maximumAge;
37 } 38 }
38 } 39 }
39 if (options.hasProperty("timeout")) { 40 if (options.hasProperty("timeout")) {
40 double timeout; 41 double timeout;
41 if (options.get("timeout", timeout)) { 42 if (DictionaryHelper::get(options, "timeout", timeout)) {
42 if (timeout < 0) 43 if (timeout < 0)
43 m_timeout = 0; 44 m_timeout = 0;
44 else if (timeout > std::numeric_limits<unsigned>::max()) 45 else if (timeout > std::numeric_limits<unsigned>::max())
45 m_timeout = std::numeric_limits<unsigned>::max(); 46 m_timeout = std::numeric_limits<unsigned>::max();
46 else 47 else
47 m_timeout = timeout; 48 m_timeout = timeout;
48 } 49 }
49 } 50 }
50 } 51 }
51 52
52 } // namespace WebCore 53 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698