Split Dictionary's get and convert into DictionaryHelper.

Source/core/animation/EffectInput.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/animation/EffectInput.h"
 
 #include "bindings/core/v8/Dictionary.h"
+#include "bindings/core/v8/DictionaryHelper.h"
 #include "core/animation/AnimationHelpers.h"
 #include "core/animation/KeyframeEffectModel.h"
 #include "core/animation/StringKeyframe.h"
 #include "core/css/parser/BisonCSSParser.h"
 #include "core/css/resolver/CSSToStyleMap.h"
 #include "core/css/resolver/StyleResolver.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "wtf/NonCopyingSort.h"
 
 namespace WebCore {
 
 PassRefPtrWillBeRawPtr<AnimationEffect> EffectInput::convert(Element* element, const Vector<Dictionary>& keyframeDictionaryVector, ExceptionState& exceptionState)
 {
     // FIXME: Remove the dependency on element.
     if (!element)
         return nullptr;
 
     StyleSheetContents* styleSheetContents = element->document().elementSheet().contents();
     StringKeyframeVector keyframes;
     bool everyFrameHasOffset = true;
     bool looselySortedByOffset = true;
     double lastOffset = -std::numeric_limits<double>::infinity();
 
     for (size_t i = 0; i < keyframeDictionaryVector.size(); ++i) {
         RefPtrWillBeRawPtr<StringKeyframe> keyframe = StringKeyframe::create();
 
         bool frameHasOffset = false;
         double offset;
-        if (keyframeDictionaryVector[i].get("offset", offset)) {
+        if (DictionaryHelper::get(keyframeDictionaryVector[i], "offset", offset)) {
             // Keyframes with offsets outside the range [0.0, 1.0] are ignored.
             if (std::isnan(offset) || offset < 0 || offset > 1)
                 continue;
 
             frameHasOffset = true;
             // The JS value null gets converted to 0 so we need to check whether the original value is null.
             if (offset == 0) {
                 ScriptValue scriptValue;
-                if (keyframeDictionaryVector[i].get("offset", scriptValue) && scriptValue.isNull())
+                if (DictionaryHelper::get(keyframeDictionaryVector[i], "offset", scriptValue) && scriptValue.isNull())
                     frameHasOffset = false;
             }
             if (frameHasOffset) {
                 keyframe->setOffset(offset);
                 if (offset < lastOffset)
                     looselySortedByOffset = false;
                 lastOffset = offset;
             }
         }
         everyFrameHasOffset = everyFrameHasOffset && frameHasOffset;
 
         keyframes.append(keyframe);
 
         String compositeString;
-        keyframeDictionaryVector[i].get("composite", compositeString);
+        DictionaryHelper::get(keyframeDictionaryVector[i], "composite", compositeString);
         if (compositeString == "add")
             keyframe->setComposite(AnimationEffect::CompositeAdd);
 
         String timingFunctionString;
-        if (keyframeDictionaryVector[i].get("easing", timingFunctionString)) {
+        if (DictionaryHelper::get(keyframeDictionaryVector[i], "easing", timingFunctionString)) {
             if (RefPtrWillBeRawPtr<CSSValue> timingFunctionValue = BisonCSSParser::parseAnimationTimingFunctionValue(timingFunctionString))
                 keyframe->setEasing(CSSToStyleMap::mapAnimationTimingFunction(timingFunctionValue.get(), true));
         }
 
         Vector<String> keyframeProperties;
         keyframeDictionaryVector[i].getOwnPropertyNames(keyframeProperties);
         for (size_t j = 0; j < keyframeProperties.size(); ++j) {
             String property = keyframeProperties[j];
             CSSPropertyID id = camelCaseCSSPropertyNameToID(property);
             if (id == CSSPropertyInvalid)
                 continue;
             String value;
-            keyframeDictionaryVector[i].get(property, value);
+            DictionaryHelper::get(keyframeDictionaryVector[i], property, value);
             keyframe->setPropertyValue(id, value, styleSheetContents);
         }
     }
 
     if (!looselySortedByOffset) {
         if (!everyFrameHasOffset) {
             exceptionState.throwDOMException(InvalidModificationError, "Keyframes are not loosely sorted by offset.");
             return nullptr;
         }
         nonCopyingSort(keyframes.begin(), keyframes.end(), Keyframe::compareOffsets);
     }
 
     RefPtrWillBeRawPtr<StringKeyframeEffectModel> keyframeEffectModel = StringKeyframeEffectModel::create(keyframes);
     if (!keyframeEffectModel->isReplaceOnly()) {
         exceptionState.throwDOMException(NotSupportedError, "Partial keyframes are not supported.");
         return nullptr;
     }
     keyframeEffectModel->forceConversionsToAnimatableValues(element);
 
     return keyframeEffectModel;
 }
 
 } // namespace WebCore