Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: Source/modules/geolocation/PositionOptions.cpp

Issue 373423002: Split Dictionary's get and convert into DictionaryHelper. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed LICENSE and windows build Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/geolocation/PositionOptions.h" 6 #include "modules/geolocation/PositionOptions.h"
7 7
8 #include "bindings/core/v8/Dictionary.h" 8 #include "bindings/core/v8/Dictionary.h"
9 #include "bindings/core/v8/DictionaryHelper.h"
9 #include <limits.h> 10 #include <limits.h>
10 11
11 namespace WebCore { 12 namespace WebCore {
12 13
13 PositionOptions* PositionOptions::create(const Dictionary& options) 14 PositionOptions* PositionOptions::create(const Dictionary& options)
14 { 15 {
15 return new PositionOptions(options); 16 return new PositionOptions(options);
16 } 17 }
17 18
18 PositionOptions::PositionOptions(const Dictionary& options) 19 PositionOptions::PositionOptions(const Dictionary& options)
19 : m_highAccuracy(false) 20 : m_highAccuracy(false)
20 , m_maximumAge(0) 21 , m_maximumAge(0)
21 , m_timeout(std::numeric_limits<unsigned>::max()) 22 , m_timeout(std::numeric_limits<unsigned>::max())
22 { 23 {
23 if (options.hasProperty("enableHighAccuracy")) 24 if (options.hasProperty("enableHighAccuracy"))
24 options.get("enableHighAccuracy", m_highAccuracy); 25 DictionaryHelper::get(options, "enableHighAccuracy", m_highAccuracy);
25 if (options.hasProperty("maximumAge")) { 26 if (options.hasProperty("maximumAge")) {
26 double maximumAge; 27 double maximumAge;
27 options.get("maximumAge", maximumAge); 28 DictionaryHelper::get(options, "maximumAge", maximumAge);
28 if (maximumAge < 0) 29 if (maximumAge < 0)
29 m_maximumAge = 0; 30 m_maximumAge = 0;
30 else if (maximumAge > std::numeric_limits<unsigned>::max()) 31 else if (maximumAge > std::numeric_limits<unsigned>::max())
31 m_maximumAge = std::numeric_limits<unsigned>::max(); 32 m_maximumAge = std::numeric_limits<unsigned>::max();
32 else 33 else
33 m_maximumAge = maximumAge; 34 m_maximumAge = maximumAge;
34 } 35 }
35 if (options.hasProperty("timeout")) { 36 if (options.hasProperty("timeout")) {
36 double timeout; 37 double timeout;
37 options.get("timeout", timeout); 38 DictionaryHelper::get(options, "timeout", timeout);
38 if (timeout < 0) 39 if (timeout < 0)
39 m_timeout = 0; 40 m_timeout = 0;
40 else if (timeout > std::numeric_limits<unsigned>::max()) 41 else if (timeout > std::numeric_limits<unsigned>::max())
41 m_timeout = std::numeric_limits<unsigned>::max(); 42 m_timeout = std::numeric_limits<unsigned>::max();
42 else 43 else
43 m_timeout = timeout; 44 m_timeout = timeout;
44 } 45 }
45 } 46 }
46 47
47 } // namespace WebCore 48 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698