Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: Source/modules/mediastream/RTCSessionDescription.cpp

Issue 373423002: Split Dictionary's get and convert into DictionaryHelper. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 } 43 }
44 44
45 static String constructIllegalTypeExceptionMessage(const String& type) 45 static String constructIllegalTypeExceptionMessage(const String& type)
46 { 46 {
47 return "Illegal value of attribute 'type' : " + type; 47 return "Illegal value of attribute 'type' : " + type;
48 } 48 }
49 49
50 RTCSessionDescription* RTCSessionDescription::create(const Dictionary& descripti onInitDict, ExceptionState& exceptionState) 50 RTCSessionDescription* RTCSessionDescription::create(const Dictionary& descripti onInitDict, ExceptionState& exceptionState)
51 { 51 {
52 String type; 52 String type;
53 bool ok = descriptionInitDict.get("type", type); 53 bool ok = DictionaryHelper::get(descriptionInitDict, "type", type);
54 if (ok && !verifyType(type)) { 54 if (ok && !verifyType(type)) {
55 exceptionState.throwDOMException(TypeMismatchError, constructIllegalType ExceptionMessage(type)); 55 exceptionState.throwDOMException(TypeMismatchError, constructIllegalType ExceptionMessage(type));
56 return nullptr; 56 return nullptr;
57 } 57 }
58 58
59 String sdp; 59 String sdp;
60 descriptionInitDict.get("sdp", sdp); 60 DictionaryHelper::get(descriptionInitDict, "sdp", sdp);
61 61
62 return new RTCSessionDescription(blink::WebRTCSessionDescription(type, sdp)) ; 62 return new RTCSessionDescription(blink::WebRTCSessionDescription(type, sdp)) ;
63 } 63 }
64 64
65 RTCSessionDescription* RTCSessionDescription::create(blink::WebRTCSessionDescrip tion webSessionDescription) 65 RTCSessionDescription* RTCSessionDescription::create(blink::WebRTCSessionDescrip tion webSessionDescription)
66 { 66 {
67 return new RTCSessionDescription(webSessionDescription); 67 return new RTCSessionDescription(webSessionDescription);
68 } 68 }
69 69
70 RTCSessionDescription::RTCSessionDescription(blink::WebRTCSessionDescription web SessionDescription) 70 RTCSessionDescription::RTCSessionDescription(blink::WebRTCSessionDescription web SessionDescription)
(...skipping 24 matching lines...) Expand all
95 { 95 {
96 m_webSessionDescription.setSDP(sdp); 96 m_webSessionDescription.setSDP(sdp);
97 } 97 }
98 98
99 blink::WebRTCSessionDescription RTCSessionDescription::webSessionDescription() 99 blink::WebRTCSessionDescription RTCSessionDescription::webSessionDescription()
100 { 100 {
101 return m_webSessionDescription; 101 return m_webSessionDescription;
102 } 102 }
103 103
104 } // namespace WebCore 104 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/modules/mediastream/RTCPeerConnection.cpp ('k') | Source/modules/mediastream/UserMediaRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698