Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: Source/modules/mediastream/RTCIceCandidate.cpp

Issue 373423002: Split Dictionary's get and convert into DictionaryHelper. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 23 matching lines...) Expand all
34 #include "bindings/core/v8/Dictionary.h" 34 #include "bindings/core/v8/Dictionary.h"
35 #include "bindings/core/v8/ExceptionMessages.h" 35 #include "bindings/core/v8/ExceptionMessages.h"
36 #include "bindings/core/v8/ExceptionState.h" 36 #include "bindings/core/v8/ExceptionState.h"
37 #include "core/dom/ExceptionCode.h" 37 #include "core/dom/ExceptionCode.h"
38 38
39 namespace WebCore { 39 namespace WebCore {
40 40
41 RTCIceCandidate* RTCIceCandidate::create(const Dictionary& dictionary, Exception State& exceptionState) 41 RTCIceCandidate* RTCIceCandidate::create(const Dictionary& dictionary, Exception State& exceptionState)
42 { 42 {
43 String candidate; 43 String candidate;
44 bool ok = dictionary.get("candidate", candidate); 44 bool ok = DictionaryHelper::get(dictionary, "candidate", candidate);
45 if (!ok || !candidate.length()) { 45 if (!ok || !candidate.length()) {
46 exceptionState.throwDOMException(TypeMismatchError, ExceptionMessages::i ncorrectPropertyType("candidate", "is not a string, or is empty.")); 46 exceptionState.throwDOMException(TypeMismatchError, ExceptionMessages::i ncorrectPropertyType("candidate", "is not a string, or is empty."));
47 return nullptr; 47 return nullptr;
48 } 48 }
49 49
50 String sdpMid; 50 String sdpMid;
51 dictionary.get("sdpMid", sdpMid); 51 DictionaryHelper::get(dictionary, "sdpMid", sdpMid);
52 52
53 unsigned short sdpMLineIndex = 0; 53 unsigned short sdpMLineIndex = 0;
54 dictionary.get("sdpMLineIndex", sdpMLineIndex); 54 DictionaryHelper::get(dictionary, "sdpMLineIndex", sdpMLineIndex);
55 55
56 return new RTCIceCandidate(blink::WebRTCICECandidate(candidate, sdpMid, sdpM LineIndex)); 56 return new RTCIceCandidate(blink::WebRTCICECandidate(candidate, sdpMid, sdpM LineIndex));
57 } 57 }
58 58
59 RTCIceCandidate* RTCIceCandidate::create(blink::WebRTCICECandidate webCandidate) 59 RTCIceCandidate* RTCIceCandidate::create(blink::WebRTCICECandidate webCandidate)
60 { 60 {
61 return new RTCIceCandidate(webCandidate); 61 return new RTCIceCandidate(webCandidate);
62 } 62 }
63 63
64 RTCIceCandidate::RTCIceCandidate(blink::WebRTCICECandidate webCandidate) 64 RTCIceCandidate::RTCIceCandidate(blink::WebRTCICECandidate webCandidate)
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 { 96 {
97 m_webCandidate.setSdpMid(sdpMid); 97 m_webCandidate.setSdpMid(sdpMid);
98 } 98 }
99 99
100 void RTCIceCandidate::setSdpMLineIndex(unsigned short sdpMLineIndex) 100 void RTCIceCandidate::setSdpMLineIndex(unsigned short sdpMLineIndex)
101 { 101 {
102 m_webCandidate.setSdpMLineIndex(sdpMLineIndex); 102 m_webCandidate.setSdpMLineIndex(sdpMLineIndex);
103 } 103 }
104 104
105 } // namespace WebCore 105 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/modules/mediastream/MediaConstraintsImpl.cpp ('k') | Source/modules/mediastream/RTCPeerConnection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698