Issue 3734003: Add support for SINGLETON_TAB disposition to BrowserNavigator....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3734003: Add support for SINGLETON_TAB disposition to BrowserNavigator.... (Closed)

Created:
10 years, 2 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add support for SINGLETON_TAB disposition to BrowserNavigator. Also makes Browser support browser::NavigatorDelegate. BUG=none TEST=BrowserNavigatorTest.Disposition_SingletonTab* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62653

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+192 lines, -94 lines)			Patch
M	chrome/browser/browser.h	View	4	3 chunks	+11 lines, -4 lines	1 comment	Download
M	chrome/browser/browser.cc	View	4 5	2 chunks	+51 lines, -22 lines	0 comments	Download
M	chrome/browser/browser_navigator.h	View	4	5 chunks	+7 lines, -21 lines	0 comments	Download
M	chrome/browser/browser_navigator.cc	View	1 2 3 4	4 chunks	+66 lines, -18 lines	0 comments	Download
M	chrome/browser/browser_navigator_browsertest.cc	View	1 2 3 4 5 6	16 chunks	+57 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

10 years, 2 months ago (2010-10-12 17:44:07 UTC) #4

LGTM

http://codereview.chromium.org/3734003/diff/23002/31002
File chrome/browser/browser.h (right):

http://codereview.chromium.org/3734003/diff/23002/31002#newcode636
chrome/browser/browser.h:636: virtual GURL GetHomePage() const;
Does this needs to be virtual?

Expand Messages | Collapse Messages