Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Unified Diff: mojo/examples/html_viewer/weburlloader_impl.h

Issue 373373002: Mojo: Refactor URLLoader interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes per review Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/examples/html_viewer/html_viewer.cc ('k') | mojo/examples/html_viewer/weburlloader_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/examples/html_viewer/weburlloader_impl.h
diff --git a/mojo/examples/html_viewer/weburlloader_impl.h b/mojo/examples/html_viewer/weburlloader_impl.h
index da302386b944e3593f77dad143a268489f9ce76a..87d97e4a73f1aac2a9b6342343b62d59bf2ccee2 100644
--- a/mojo/examples/html_viewer/weburlloader_impl.h
+++ b/mojo/examples/html_viewer/weburlloader_impl.h
@@ -23,11 +23,9 @@ class WebURLRequestExtraData : public blink::WebURLRequest::ExtraData {
virtual ~WebURLRequestExtraData();
URLResponsePtr synthetic_response;
- ScopedDataPipeConsumerHandle synthetic_response_body_stream;
};
-class WebURLLoaderImpl : public blink::WebURLLoader,
- public URLLoaderClient {
+class WebURLLoaderImpl : public blink::WebURLLoader {
public:
explicit WebURLLoaderImpl(NetworkService* network_service);
@@ -43,19 +41,15 @@ class WebURLLoaderImpl : public blink::WebURLLoader,
virtual void cancel() OVERRIDE;
virtual void setDefersLoading(bool defers_loading) OVERRIDE;
- // URLLoaderClient methods:
- virtual void OnReceivedRedirect(URLResponsePtr response,
- const String& new_url,
- const String& new_method) OVERRIDE;
- virtual void OnReceivedResponse(URLResponsePtr response) OVERRIDE;
- virtual void OnReceivedError(NetworkErrorPtr error) OVERRIDE;
- virtual void OnReceivedEndOfResponseBody() OVERRIDE;
-
+ void OnReceivedResponse(URLResponsePtr response);
+ void OnReceivedError(URLResponsePtr response);
+ void OnReceivedRedirect(URLResponsePtr response);
void ReadMore();
void WaitToReadMore();
void OnResponseBodyStreamReady(MojoResult result);
blink::WebURLLoaderClient* client_;
+ GURL url_;
URLLoaderPtr url_loader_;
ScopedDataPipeConsumerHandle response_body_stream_;
common::HandleWatcher handle_watcher_;
« no previous file with comments | « mojo/examples/html_viewer/html_viewer.cc ('k') | mojo/examples/html_viewer/weburlloader_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698