Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 373343003: Componentize TemplateURLFetcher (Closed)

Created:
6 years, 5 months ago by hashimoto
Modified:
6 years, 5 months ago
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Componentize TemplateURLFetcher Move TemplateURLFetcher and TemplateURLParser to components/search_engines Add dependencies on libxml and ui/gfx (for gfx::kFaviconSize) BUG=371535 TEST=build TBR=sky@chromium.org for include fix under chrome/browser/{importer,profiles} TBR=danakj@chromium.org as an owner of ui/gfx, a DEPS line moved from chrome/browser/search_engines to components/search_engines TBR=brettw@chromium.org as an owner of third_party/libxml, a DEPS line moved from chrome/browser/search_engines to components/search_engines Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282237

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -920 lines) Patch
M chrome/browser/importer/in_process_importer_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/search_engines/template_url_fetcher.h View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/browser/search_engines/template_url_fetcher.cc View 1 chunk +0 lines, -265 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/search_engines/template_url_parser.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/search_engines/template_url_parser.cc View 1 chunk +0 lines, -493 lines 0 comments Download
M chrome/browser/search_engines/template_url_parser_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M components/search_engines.gypi View 2 chunks +6 lines, -1 line 0 comments Download
M components/search_engines/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
A + components/search_engines/template_url_fetcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/search_engines/template_url_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/search_engines/template_url_parser.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/search_engines/template_url_parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
hashimoto
6 years, 5 months ago (2014-07-09 09:29:02 UTC) #1
Peter Kasting
LGTM
6 years, 5 months ago (2014-07-09 18:50:54 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-10 02:34:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/373343003/20001
6 years, 5 months ago (2014-07-10 02:36:00 UTC) #4
hashimoto
TBRing following people: -sky@chromium.org for include fix under chrome/browser/{importer,profiles} -danakj@chromium.org as an owner of ui/gfx, ...
6 years, 5 months ago (2014-07-10 02:49:47 UTC) #5
hashimoto
(sending to the correct addresses) TBRing following people: -sky@chromium.org for include fix under chrome/browser/{importer,profiles} -danakj@chromium.org ...
6 years, 5 months ago (2014-07-10 02:50:36 UTC) #6
hashimoto
The CQ bit was unchecked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-10 02:50:41 UTC) #7
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-10 02:50:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/373343003/20001
6 years, 5 months ago (2014-07-10 02:52:14 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 03:25:28 UTC) #10
Message was sent while issue was closed.
Change committed as 282237

Powered by Google App Engine
This is Rietveld 408576698