content/browser/browser_plugin/browser_plugin_guest.cc - Issue 373323003: Cache the current WebPreferences on RenderViewHostImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 373323003: Cache the current WebPreferences on RenderViewHostImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix android build. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index ef729e4b0596498a9955642a94894392af461e54..1da2fdd3f1525206597a0251e8920740ec887dcb 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -223,7 +223,10 @@ void BrowserPluginGuest::Initialize(

new BrowserPluginMsg_GuestContentWindowReady(instance_id_,

guest_routing_id));

- WebPreferences prefs = GetWebContents()->GetWebkitPrefs();

+ // TODO(chrishtr): this code is wrong. The navigate_on_drag_drop field will

+ // be reset again the next time preferences are updated.

+ WebPreferences prefs =

+ GetWebContents()->GetRenderViewHost()->GetWebkitPreferences();

prefs.navigate_on_drag_drop = false;

GetWebContents()->GetRenderViewHost()->UpdateWebkitPreferences(prefs);