chrome/browser/android/voice_search_tab_helper.cc - Issue 373323003: Cache the current WebPreferences on RenderViewHostImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/voice_search_tab_helper.cc

Issue 373323003: Cache the current WebPreferences on RenderViewHostImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix android build. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/voice_search_tab_helper.cc

diff --git a/chrome/browser/android/voice_search_tab_helper.cc b/chrome/browser/android/voice_search_tab_helper.cc

index c8f10db3662fae873a0708f60ee2a395dd6b40b3..52f0c360f2a1fec8e3dcd030819a3f7dfbd6a6d4 100644

--- a/chrome/browser/android/voice_search_tab_helper.cc

+++ b/chrome/browser/android/voice_search_tab_helper.cc

@@ -32,6 +32,8 @@ static void UpdateAutoplayStatus(JNIEnv* env,

if (!prefs.user_gesture_required_for_media_playback)

return;

+ // TODO(chrishtr): this is wrong. user_gesture_required_for_media_playback

+ // will be reset the next time a preference changes.

prefs.user_gesture_required_for_media_playback =

!google_util::IsGoogleSearchUrl(web_contents->GetLastCommittedURL());

host->UpdateWebkitPreferences(prefs);