chrome/browser/chrome_content_browser_client.cc - Issue 373323003: Cache the current WebPreferences on RenderViewHostImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 373323003: Cache the current WebPreferences on RenderViewHostImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 191efab6f56ec59fb060787e8f489f8442493633..816b1e0a9d12f76a096573acf033d44577a4f564 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -2483,6 +2483,8 @@ void ChromeContentBrowserClient::OverrideWebkitPrefs(

}

DCHECK(!web_prefs->default_encoding.empty());

+ // Note: it's not posible for kExtensionsScheme to change during the lifetime

+ // of the process.

WebContents* web_contents = WebContents::FromRenderViewHost(rvh);

extensions::ViewType view_type = extensions::GetViewType(web_contents);

ExtensionService* service =