Cache the current WebPreferences on RenderViewHostImpl.

chrome/browser/printing/print_dialog_cloud.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_dialog_cloud.h"
 
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 343 matching lines @@
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   switch (type) {
     case content::NOTIFICATION_LOAD_STOP: {
       GURL url = web_ui()->GetWebContents()->GetURL();
       if (IsCloudPrintDialogUrl(url)) {
         // Take the opportunity to set some (minimal) additional
         // script permissions required for the web UI.
         RenderViewHost* rvh = web_ui()->GetWebContents()->GetRenderViewHost();
         if (rvh) {
+          // TODO(chrishtr): this is wrong. allow_scripts_to_close_windows will
+          // be reset the next time a preference changes.
           WebPreferences webkit_prefs = rvh->GetWebkitPreferences();
           webkit_prefs.allow_scripts_to_close_windows = true;
           rvh->UpdateWebkitPreferences(webkit_prefs);
         } else {
           NOTREACHED();
         }
         // Choose one or the other.  If you need to debug, bring up the
         // debugger.  You can then use the various chrome.send()
         // registrations above to kick of the various function calls,
         // including chrome.send("SendPrintData") in the javaScript
@@ skipping 401 matching lines @@
 
       print_dialog_cloud::CreatePrintDialogForFile(profile, NULL,
           cloud_print_file, print_job_title, print_job_print_ticket, file_type);
       return true;
     }
   }
   return false;
 }
 
 }  // namespace print_dialog_cloud