Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 373323003: Cache the current WebPreferences on RenderViewHostImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 virtual SiteInstance* GetSiteInstance() const OVERRIDE; 200 virtual SiteInstance* GetSiteInstance() const OVERRIDE;
201 virtual bool IsRenderViewLive() const OVERRIDE; 201 virtual bool IsRenderViewLive() const OVERRIDE;
202 virtual void NotifyMoveOrResizeStarted() OVERRIDE; 202 virtual void NotifyMoveOrResizeStarted() OVERRIDE;
203 virtual void SetWebUIProperty(const std::string& name, 203 virtual void SetWebUIProperty(const std::string& name,
204 const std::string& value) OVERRIDE; 204 const std::string& value) OVERRIDE;
205 virtual void Zoom(PageZoom zoom) OVERRIDE; 205 virtual void Zoom(PageZoom zoom) OVERRIDE;
206 virtual void SyncRendererPrefs() OVERRIDE; 206 virtual void SyncRendererPrefs() OVERRIDE;
207 virtual WebPreferences GetWebkitPreferences() OVERRIDE; 207 virtual WebPreferences GetWebkitPreferences() OVERRIDE;
208 virtual void UpdateWebkitPreferences( 208 virtual void UpdateWebkitPreferences(
209 const WebPreferences& prefs) OVERRIDE; 209 const WebPreferences& prefs) OVERRIDE;
210 virtual void OnWebkitPreferencesChanged() OVERRIDE;
210 virtual void GetAudioOutputControllers( 211 virtual void GetAudioOutputControllers(
211 const GetAudioOutputControllersCallback& callback) const OVERRIDE; 212 const GetAudioOutputControllersCallback& callback) const OVERRIDE;
212 virtual void SelectWordAroundCaret() OVERRIDE; 213 virtual void SelectWordAroundCaret() OVERRIDE;
213 214
214 #if defined(OS_ANDROID) 215 #if defined(OS_ANDROID)
215 virtual void ActivateNearestFindResult(int request_id, 216 virtual void ActivateNearestFindResult(int request_id,
216 float x, 217 float x,
217 float y) OVERRIDE; 218 float y) OVERRIDE;
218 virtual void RequestFindMatchRects(int current_version) OVERRIDE; 219 virtual void RequestFindMatchRects(int current_version) OVERRIDE;
219 #endif 220 #endif
(...skipping 17 matching lines...) Expand all
237 int opener_route_id, 238 int opener_route_id,
238 int proxy_route_id, 239 int proxy_route_id,
239 int32 max_page_id, 240 int32 max_page_id,
240 bool window_was_created_with_opener); 241 bool window_was_created_with_opener);
241 242
242 base::TerminationStatus render_view_termination_status() const { 243 base::TerminationStatus render_view_termination_status() const {
243 return render_view_termination_status_; 244 return render_view_termination_status_;
244 } 245 }
245 246
246 // Returns the content specific prefs for this RenderViewHost. 247 // Returns the content specific prefs for this RenderViewHost.
247 WebPreferences GetWebkitPrefs(const GURL& url); 248 WebPreferences ComputeWebkitPrefs(const GURL& url);
248 249
249 // Sends the given navigation message. Use this rather than sending it 250 // Sends the given navigation message. Use this rather than sending it
250 // yourself since this does the internal bookkeeping described below. This 251 // yourself since this does the internal bookkeeping described below. This
251 // function takes ownership of the provided message pointer. 252 // function takes ownership of the provided message pointer.
252 // 253 //
253 // If a cross-site request is in progress, we may be suspended while waiting 254 // If a cross-site request is in progress, we may be suspended while waiting
254 // for the onbeforeunload handler, so this function might buffer the message 255 // for the onbeforeunload handler, so this function might buffer the message
255 // rather than sending it. 256 // rather than sending it.
256 // TODO(nasko): Remove this method once all callers are converted to use 257 // TODO(nasko): Remove this method once all callers are converted to use
257 // RenderFrameHostImpl. 258 // RenderFrameHostImpl.
(...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after
637 // Called after receiving the SwapOutACK when the RVH is in state pending 638 // Called after receiving the SwapOutACK when the RVH is in state pending
638 // shutdown. Also called if the unload timer times out. 639 // shutdown. Also called if the unload timer times out.
639 // TODO(nasko): Move to RenderFrameHost, as this is per-frame state. 640 // TODO(nasko): Move to RenderFrameHost, as this is per-frame state.
640 base::Closure pending_shutdown_on_swap_out_; 641 base::Closure pending_shutdown_on_swap_out_;
641 642
642 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_; 643 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_;
643 644
644 // True if the current focused element is editable. 645 // True if the current focused element is editable.
645 bool is_focused_element_editable_; 646 bool is_focused_element_editable_;
646 647
648 // This is updated every time UpdateWebkitPreferences is called. That method
649 // is in turn called when any of the settings change that the WebPreferences
650 // values depend on.
651 scoped_ptr<WebPreferences> web_preferences_;
652
647 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl); 653 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
648 }; 654 };
649 655
650 #if defined(COMPILER_MSVC) 656 #if defined(COMPILER_MSVC)
651 #pragma warning(pop) 657 #pragma warning(pop)
652 #endif 658 #endif
653 659
654 } // namespace content 660 } // namespace content
655 661
656 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 662 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698