Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 373323002: Avoid unnecessary hashing in OrderedHashTable (Closed)

Created:
6 years, 5 months ago by adamk
Modified:
6 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, arv (Not doing code reviews), rossberg, Dmitry Lomov (no reviews)
Project:
v8
Visibility:
Public.

Description

Avoid unnecessary hashing in OrderedHashTable Add an overload of OrderedHashTable::FindEntry that takes a hash along with the key to allow callsites which need to re-use the hash (such as Add()) to avoid recomputing it. On my Macbook this results in improvements on the Collections microbenchmarks: Map-Collections: +4% Set-Collections: +5% R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22308

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 7 chunks +24 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
adamk
6 years, 5 months ago (2014-07-08 22:54:23 UTC) #1
Michael Starzinger
LGTM.
6 years, 5 months ago (2014-07-09 07:41:56 UTC) #2
adamk
6 years, 5 months ago (2014-07-09 16:19:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22308 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698