Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: tools/perf/benchmarks/jsgamebench.py

Issue 373233002: Update jsgamebench to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/jsgamebench.py
diff --git a/tools/perf/benchmarks/jsgamebench.py b/tools/perf/benchmarks/jsgamebench.py
index 8d1c8c16c8a26783dde0c19b50f277e4d802336e..cf057d82f82811809bf3eb0cc55790e4af088b56 100644
--- a/tools/perf/benchmarks/jsgamebench.py
+++ b/tools/perf/benchmarks/jsgamebench.py
@@ -15,6 +15,7 @@ import os
from telemetry import benchmark
from telemetry.page import page_measurement
from telemetry.page import page_set
+from telemetry.value import scalar
class _JsgamebenchMeasurement(page_measurement.PageMeasurement):
@@ -28,7 +29,8 @@ class _JsgamebenchMeasurement(page_measurement.PageMeasurement):
js_get_results = 'document.getElementById("perfscore0").innerHTML'
result = int(tab.EvaluateJavaScript(js_get_results))
- results.Add('Score', 'score (bigger is better)', result)
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, 'Score', 'score (bigger is better)', result))
@benchmark.Disabled
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698