Implemented parsing of the ignored failing tests spec and ignoring respective failures.

Implemented parsing of the ignored failing tests spec and ignoring respective failures.

Depends on https://codereview.chromium.org/376653002/

BUG=390600
R=eseidel@chromium.org, stip@chromium.org, hinoka@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=284418

[Sergiy Byelozyorov, 2014-07-08 19:38:54]

PTAL

[Sergiy Byelozyorov, 2014-07-08 19:42:11]

Added stip@. PTAL

[Sergiy Byelozyorov, 2014-07-09 13:34:50]

Added sergeyberezin@

[Sergiy Byelozyorov, 2014-07-09 13:38:58]

It appears sergeyberezin@ is not an OWNER. Adding hinoka@ instead.

[eseidel, 2014-07-09 16:07:02]

https://codereview.chromium.org/373223003/diff/20001/scripts/common/unittests...
File scripts/common/unittests/gtest_utils_test.py (right):

https://codereview.chromium.org/373223003/diff/20001/scripts/common/unittests...
scripts/common/unittests/gtest_utils_test.py:752: os.remove(spec_filename)
It's really unfortunate that this test touches the filesystem.  That can cause
tests to flake or fail in unexpected ways.

[Sergiy Byelozyorov, 2014-07-09 17:23:42]

https://codereview.chromium.org/373223003/diff/20001/scripts/common/unittests...
File scripts/common/unittests/gtest_utils_test.py (right):

https://codereview.chromium.org/373223003/diff/20001/scripts/common/unittests...
scripts/common/unittests/gtest_utils_test.py:752: os.remove(spec_filename)
On 2014/07/09 16:07:02, eseidel wrote:
> It's really unfortunate that this test touches the filesystem.  That can cause
> tests to flake or fail in unexpected ways.
I wish I could mock 'open' function with self.mock. Then there wouldn't need to
be doing that. But it seems to be a common practice to just use files for that.
tempfile.mkstemp promises to create the file in the safest way possible, so this
should not be flaky.

[ghost stip (do not use), 2014-07-11 18:24:07]

https://chromiumcodereview.appspot.com/373223003/diff/100001/scripts/common/g...
File scripts/common/gtest_utils.py (right):

https://chromiumcodereview.appspot.com/373223003/diff/100001/scripts/common/g...
scripts/common/gtest_utils.py:518: os.path.abspath(chrome_dir), 'tools',
'ignorer_bot',
I'm not sure I understand what is going on here. I thought the ignore file was
checked into src/tools/ignorer_bot. It seems like you should have a fixed path
to that if you have src/ right?

https://chromiumcodereview.appspot.com/373223003/diff/100001/scripts/common/g...
scripts/common/gtest_utils.py:535: match = re.match(
Again, I strongly recommend using YAML for this. This parsing code will only get
more gnarly over time.

https://chromiumcodereview.appspot.com/373223003/diff/100001/scripts/common/g...
scripts/common/gtest_utils.py:536: r'^http://crbug.com/\d+'     # Issue URL.
https://

[Sergiy Byelozyorov, 2014-07-16 16:23:25]

https://codereview.chromium.org/373223003/diff/100001/scripts/common/gtest_ut...
File scripts/common/gtest_utils.py (right):

https://codereview.chromium.org/373223003/diff/100001/scripts/common/gtest_ut...
scripts/common/gtest_utils.py:518: os.path.abspath(chrome_dir), 'tools',
'ignorer_bot',
On 2014/07/11 18:24:07, stip wrote:
> I'm not sure I understand what is going on here. I thought the ignore file was
> checked into src/tools/ignorer_bot. It seems like you should have a fixed path
> to that if you have src/ right?

In the runtest.py we only have a path to the build dir, which can be different
on different platforms. But we know for sure that when going up the directory
structure we will eventually find the chrome dir.

https://codereview.chromium.org/373223003/diff/100001/scripts/common/gtest_ut...
scripts/common/gtest_utils.py:535: match = re.match(
On 2014/07/11 18:24:07, stip wrote:
> Again, I strongly recommend using YAML for this. This parsing code will only
get
> more gnarly over time.
Let's discuss this today.

https://codereview.chromium.org/373223003/diff/100001/scripts/common/gtest_ut...
scripts/common/gtest_utils.py:536: r'^http://crbug.com/\d+'     # Issue URL.
On 2014/07/11 18:24:07, stip wrote:
> https://

In fact this should go away altogether as now we just use crbug.com/12345. But
this may change after today's discussion.

[Sergiy Byelozyorov, 2014-07-18 10:35:33]

PTAL

[eseidel, 2014-07-18 16:35:16]

Seems fine.  I dont' have owner powers on that file.

[ghost stip (do not use), 2014-07-19 01:09:06]

lgtm with correction of a typo

https://chromiumcodereview.appspot.com/373223003/diff/120001/scripts/common/g...
File scripts/common/gtest_utils.py (right):

https://chromiumcodereview.appspot.com/373223003/diff/120001/scripts/common/g...
scripts/common/gtest_utils.py:498: def
ParseIngoredFailedTestSpec(dir_in_chrome):
ParseIgnored

https://chromiumcodereview.appspot.com/373223003/diff/120001/scripts/common/g...
scripts/common/gtest_utils.py:536: r'^crbug.com/\d+'           # Issue URL.
my general experience of maintaining regex-based parsers has been
http://giphy.com/gifs/8J7iphFhJogBq

I'm going to make one last plea that you use a serialization like yaml or json

https://chromiumcodereview.appspot.com/373223003/diff/120001/scripts/common/g...
scripts/common/gtest_utils.py:567: parsed_spec =
self.ParseIngoredFailedTestSpec(build_dir)
ParseIgnored

[Sergiy Byelozyorov, 2014-07-21 12:39:57]

https://codereview.chromium.org/373223003/diff/120001/scripts/common/gtest_ut...
File scripts/common/gtest_utils.py (right):

https://codereview.chromium.org/373223003/diff/120001/scripts/common/gtest_ut...
scripts/common/gtest_utils.py:498: def
ParseIngoredFailedTestSpec(dir_in_chrome):
On 2014/07/19 01:09:06, stip wrote:
> ParseIgnored

Done.

https://codereview.chromium.org/373223003/diff/120001/scripts/common/gtest_ut...
scripts/common/gtest_utils.py:536: r'^crbug.com/\d+'           # Issue URL.
On 2014/07/19 01:09:06, stip wrote:
> my general experience of maintaining regex-based parsers has been
> http://giphy.com/gifs/8J7iphFhJogBq
> 
> I'm going to make one last plea that you use a serialization like yaml or json

I will. But in the next version. For now we need something to start disabling
tests. Once the code for layout tests is refactored into depot_tools, we can
discuss and rewrite it as JSON.

https://codereview.chromium.org/373223003/diff/120001/scripts/common/gtest_ut...
scripts/common/gtest_utils.py:567: parsed_spec =
self.ParseIngoredFailedTestSpec(build_dir)
On 2014/07/19 01:09:06, stip wrote:
> ParseIgnored

Done.

[Sergiy Byelozyorov, 2014-07-21 12:40:32]

The CQ bit was checked by sergiyb@chromium.org

[commit-bot: I haz the power, 2014-07-21 12:40:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergiyb@chromium.org/373223003/140001

[commit-bot: I haz the power, 2014-07-21 12:42:41]

Change committed as 284418