Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 373203002: Fix Android webview channel ID initialization. (Closed)

Created:
6 years, 5 months ago by sgurun-gerrit only
Modified:
6 years, 5 months ago
Reviewers:
boliu
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix Android webview channel ID initialization. Android webview is missing initialization of ServerBoundCertService. Add logic to initialize it. Internal bug: b/14050903 BUG=392235 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M android_webview/browser/net/aw_url_request_context_getter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sgurun-gerrit only
@boliu: need owner's review
6 years, 5 months ago (2014-07-08 18:41:34 UTC) #1
boliu
lgtm
6 years, 5 months ago (2014-07-08 18:58:49 UTC) #2
sgurun-gerrit only
The CQ bit was checked by sgurun@chromium.org
6 years, 5 months ago (2014-07-08 20:07:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sgurun@chromium.org/373203002/1
6 years, 5 months ago (2014-07-08 20:08:41 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 00:13:10 UTC) #5
Message was sent while issue was closed.
Change committed as 281897

Powered by Google App Engine
This is Rietveld 408576698