Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 373183002: Support ES6 Map and Set in heap profiler (Closed)

Created:
6 years, 5 months ago by yurys
Modified:
6 years, 5 months ago
Reviewers:
alph, Yang, rossberg, loislo
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Support ES6 Map and Set in heap profiler Added special handling for Map and Set in the heap snapshot generator. Extracted common base type from JSMap/JSSet similar to JSWeakMap/JSWeakSet. After handling collection specific properties all collections are processed as regular JSObject to make sure all regular properties set on them are present in the heap snapshot. BUG=v8:3368 LOG=Y R=alph@chromium.org, rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22311 Committed: https://code.google.com/p/v8/source/detail?r=22316

Patch Set 1 #

Patch Set 2 : Fixed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -24 lines) Patch
M src/heap-snapshot-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap-snapshot-generator.cc View 2 chunks +16 lines, -4 lines 0 comments Download
M src/objects.h View 1 2 chunks +17 lines, -15 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 4 chunks +90 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yurys
6 years, 5 months ago (2014-07-08 16:59:57 UTC) #1
alph
lgtm
6 years, 5 months ago (2014-07-08 17:13:55 UTC) #2
yurys
Yang: please do OWNERS review.
6 years, 5 months ago (2014-07-08 17:15:54 UTC) #3
Yang
looking good, but I'd like to run the Object hierarchy change by Andreas.
6 years, 5 months ago (2014-07-09 07:48:33 UTC) #4
rossberg
On 2014/07/09 07:48:33, Yang wrote: > looking good, but I'd like to run the Object ...
6 years, 5 months ago (2014-07-09 10:26:10 UTC) #5
rossberg
On 2014/07/09 10:26:10, rossberg wrote: > On 2014/07/09 07:48:33, Yang wrote: > > looking good, ...
6 years, 5 months ago (2014-07-09 10:36:17 UTC) #6
yurys
Committed patchset #2 manually as r22311 (presubmit successful).
6 years, 5 months ago (2014-07-10 07:25:03 UTC) #7
yurys
6 years, 5 months ago (2014-07-10 10:55:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r22316 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698