LayoutTests/fast/dom/HTMLDialogElement/dialog-return-value.html - Issue 373043004: IDL: Treat undefined as missing for optional arguments with defaults

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/HTMLDialogElement/dialog-return-value.html

Issue 373043004: IDL: Treat undefined as missing for optional arguments with defaults (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/DOMImplementation/createHTMLDocument-optional-title-expected.txt ('k') | LayoutTests/fast/dom/HTMLDialogElement/dialog-return-value-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/HTMLDialogElement/dialog-return-value.html

diff --git a/LayoutTests/fast/dom/HTMLDialogElement/dialog-return-value.html b/LayoutTests/fast/dom/HTMLDialogElement/dialog-return-value.html

index 9d4262cd50fca3ddb22a7fa4b124d7d4d7261070..e051e5b963012e20e7d990db517404d7c6851f8a 100644

--- a/LayoutTests/fast/dom/HTMLDialogElement/dialog-return-value.html

+++ b/LayoutTests/fast/dom/HTMLDialogElement/dialog-return-value.html

@@ -40,6 +40,11 @@ dialog.show();

dialog.close();

shouldBe("dialog.returnValue", "'Should not change because no argument to close()'");

+dialog.returnValue = 'Should not change because of undefined argument to close()';

+dialog.show();

+dialog.close(undefined);

+shouldBe("dialog.returnValue", "'Should not change because of undefined argument to close()'");

dialog.returnValue = 'Should not change because close() is invalid';

shouldThrow("dialog.close('blah')", '"InvalidStateError: Failed to execute \'close\' on \'HTMLDialogElement\': The element does not have an \'open\' attribute, and therefore cannot be closed."');

shouldBe("dialog.returnValue", "'Should not change because close() is invalid'");