LayoutTests/fast/dom/HTMLDialogElement/dialog-return-value-expected.txt - Issue 373043004: IDL: Treat undefined as missing for optional arguments with defaults

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLDialogElement/dialog-return-value-expected.txt

Issue 373043004: IDL: Treat undefined as missing for optional arguments with defaults (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLDialogElement/dialog-return-value.html ('k') | LayoutTests/fast/dom/NodeIterator/NodeIterator-basic.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 Tests that dialog.returnValue is settable and returns the last value set.	1 Tests that dialog.returnValue is settable and returns the last value set.

2	2

3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

4	4

5	5

6 PASS dialog.returnValue is ''	6 PASS dialog.returnValue is ''

7 PASS dialog.returnValue is 'Setting value directly'	7 PASS dialog.returnValue is 'Setting value directly'

8 PASS dialog.returnValue is 'null'	8 PASS dialog.returnValue is 'null'

9 PASS dialog.returnValue is ''	9 PASS dialog.returnValue is ''

10 PASS dialog.returnValue is '7'	10 PASS dialog.returnValue is '7'

11 PASS dialog.returnValue is 'Return value set from close()'	11 PASS dialog.returnValue is 'Return value set from close()'

12 PASS dialog.returnValue is ''	12 PASS dialog.returnValue is ''

13 PASS dialog.returnValue is 'null'	13 PASS dialog.returnValue is 'null'

14 PASS dialog.returnValue is 'Should not change because no argument to close()'	14 PASS dialog.returnValue is 'Should not change because no argument to close()'

	15 PASS dialog.returnValue is 'Should not change because of undefined argument to c lose()'

15 PASS dialog.close('blah') threw exception InvalidStateError: Failed to execute ' close' on 'HTMLDialogElement': The element does not have an 'open' attribute, an d therefore cannot be closed..	16 PASS dialog.close('blah') threw exception InvalidStateError: Failed to execute ' close' on 'HTMLDialogElement': The element does not have an 'open' attribute, an d therefore cannot be closed..

16 PASS dialog.returnValue is 'Should not change because close() is invalid'	17 PASS dialog.returnValue is 'Should not change because close() is invalid'

17 PASS successfullyParsed is true	18 PASS successfullyParsed is true

18	19

19 TEST COMPLETE	20 TEST COMPLETE

20	21

OLD	NEW