LayoutTests/fast/dom/Comment/comment-constructor.html - Issue 373043004: IDL: Treat undefined as missing for optional arguments with defaults

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Comment/comment-constructor.html

Issue 373043004: IDL: Treat undefined as missing for optional arguments with defaults (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css/shorthand-setProperty-important-expected.txt ('k') | LayoutTests/fast/dom/Comment/comment-constructor-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <body>	2 <body>

3 <script src="../../../resources/js-test.js"></script>	3 <script src="../../../resources/js-test.js"></script>

4 <script>	4 <script>

5	5

6 description('This tests that Comment is constructable.');	6 description('This tests that Comment is constructable.');

7	7

8 shouldBe('new Comment("one").data', '"one"');	8 shouldBe('new Comment("one").data', '"one"');

9 shouldBe('new Comment().data', '""');	9 shouldBe('new Comment().data', '""');

	10 shouldBe('new Comment(undefined).data', '""');

	11 shouldBe('new Comment(null).data', '"null"');

10 shouldBe('new Comment("two").ownerDocument', 'document');	12 shouldBe('new Comment("two").ownerDocument', 'document');

11	13

12 shouldBe('typeof new Comment', '"object"');	14 shouldBe('typeof new Comment', '"object"');

13 shouldBe('Object.prototype.toString.call(new Comment)', '"[object Comment]"');	15 shouldBe('Object.prototype.toString.call(new Comment)', '"[object Comment]"');

14 shouldBeTrue('new Comment instanceof Comment');	16 shouldBeTrue('new Comment instanceof Comment');

15 shouldBe('Object.getPrototypeOf(new Comment)', 'Comment.prototype');	17 shouldBe('Object.getPrototypeOf(new Comment)', 'Comment.prototype');

16	18

17 var frame = document.createElement('iframe');	19 var frame = document.createElement('iframe');

18 document.body.appendChild(frame);	20 document.body.appendChild(frame);

19 var innerWindow = frame.contentWindow;	21 var innerWindow = frame.contentWindow;

20 var innerDocument = frame.contentDocument;	22 var innerDocument = frame.contentDocument;

21	23

22 shouldBe('new innerWindow.Comment("three").ownerDocument', 'innerDocument')	24 shouldBe('new innerWindow.Comment("three").ownerDocument', 'innerDocument')

23 shouldBeTrue('new innerWindow.Comment instanceof innerWindow.Comment');	25 shouldBeTrue('new innerWindow.Comment instanceof innerWindow.Comment');

24 shouldBe('Object.getPrototypeOf(new innerWindow.Comment)', 'innerWindow.Comment. prototype');	26 shouldBe('Object.getPrototypeOf(new innerWindow.Comment)', 'innerWindow.Comment. prototype');

25	27

26 </script>	28 </script>

OLD	NEW