Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 373024: Fix regression in which NPRES_NETWORK_ERR instead of NPRES_USER_BREAK was pas... (Closed)

Created:
11 years, 1 month ago by jam
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam
Visibility:
Public.

Description

Fix regression in which NPRES_NETWORK_ERR instead of NPRES_USER_BREAK was passed to a plugin when a tab that it created was closed by the user. This ended up stopping the launching video. BUG=23102 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M webkit/glue/webplugin_impl.cc View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
11 years, 1 month ago (2009-11-09 00:58:24 UTC) #1
jam
Adding dglazkov if he can get to it sooner.
11 years, 1 month ago (2009-11-09 02:48:51 UTC) #2
dglazkov
11 years, 1 month ago (2009-11-09 03:08:54 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698