Explicitly set selection ranges in PasswordAutofillAgentTest

Explicitly set selection ranges in PasswordAutofillAgentTest.

Previously, the selection ranges were set implicitly when setValue() was
called.  After [ https://codereview.chromium.org/258063005/ ], setValue()
will no longer implicitly set a field's selection range, so do so explicitly.

BUG=367736, 133242
TEST=browser_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281975

[harpreet.sk, 2014-07-08 15:42:13]

ptal..

[Ilya Sherman, 2014-07-08 23:02:47]

It looks like your Blink change is breaking password autofill behavior.  I don't
think this change is appropriate.

[tkent, 2014-07-08 23:47:26]

On 2014/07/08 23:02:47, Ilya Sherman wrote:
> It looks like your Blink change is breaking password autofill behavior.  I
don't
> think this change is appropriate.

isherman, I think the resultant selection is changed because the selection just
after the first username_element_.setValue() on each of tests is changed. I
don't think password autofill behavior is changed.

Anyway, this CL depends on https://codereview.chromium.org/258063005/ and we
can't land it.
We need to make the tests workable with/without
https://codereview.chromium.org/258063005/  (by focusing on username_element_?),
or need to follow the following steps:
1. Disable the tests
2. Land https://codereview.chromium.org/258063005/
3. Wait for a Blink roll
4. Fix the tests and enable them.

[Ilya Sherman, 2014-07-08 23:51:41]

On 2014/07/08 23:47:26, tkent wrote:
> On 2014/07/08 23:02:47, Ilya Sherman wrote:
> > It looks like your Blink change is breaking password autofill behavior.  I
> don't
> > think this change is appropriate.
> 
> isherman, I think the resultant selection is changed because the selection
just
> after the first username_element_.setValue() on each of tests is changed. I
> don't think password autofill behavior is changed.

I see.  Yes, I think the right solution is to update each test to set the cursor
position to the end of the field as well.

[harpreet.sk, 2014-07-09 03:16:17]

On 2014/07/08 23:51:41, Ilya Sherman wrote:

> I see.  Yes, I think the right solution is to update each test to set the
cursor
> position to the end of the field as well.


Uploaded new patch updating the test to set cursor position to the end of the
field.. ptal..

[Ilya Sherman, 2014-07-09 03:22:10]

LGTM, thanks.

[Ilya Sherman, 2014-07-09 03:22:14]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2014-07-09 03:22:49]

The CQ bit was unchecked by isherman@chromium.org

[Ilya Sherman, 2014-07-09 03:25:30]

Please note that I've updated the CL description.

[Ilya Sherman, 2014-07-09 03:25:34]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2014-07-09 03:26:07]

The CQ bit was unchecked by isherman@chromium.org

[Ilya Sherman, 2014-07-09 03:26:07]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2014-07-09 03:26:31]

The CQ bit was unchecked by isherman@chromium.org

[Ilya Sherman, 2014-07-09 03:26:31]

The CQ bit was checked by isherman@chromium.org

[harpreet.sk, 2014-07-09 03:27:02]

On 2014/07/09 03:25:30, Ilya Sherman wrote:
> Please note that I've updated the CL description.

thanks :)

[commit-bot: I haz the power, 2014-07-09 03:27:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/373023004/20001

[commit-bot: I haz the power, 2014-07-09 05:20:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-07-09 06:17:50]

Change committed as 281975