Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 373023004: Explicitly set selection ranges in PasswordAutofillAgentTest (Closed)

Created:
6 years, 5 months ago by harpreet.sk
Modified:
6 years, 5 months ago
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Explicitly set selection ranges in PasswordAutofillAgentTest. Previously, the selection ranges were set implicitly when setValue() was called. After [ https://codereview.chromium.org/258063005/ ], setValue() will no longer implicitly set a field's selection range, so do so explicitly. BUG=367736, 133242 TEST=browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281975

Patch Set 1 #

Patch Set 2 : Addressing changes as per comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
harpreet.sk
ptal..
6 years, 5 months ago (2014-07-08 15:42:13 UTC) #1
Ilya Sherman
It looks like your Blink change is breaking password autofill behavior. I don't think this ...
6 years, 5 months ago (2014-07-08 23:02:47 UTC) #2
tkent
On 2014/07/08 23:02:47, Ilya Sherman wrote: > It looks like your Blink change is breaking ...
6 years, 5 months ago (2014-07-08 23:47:26 UTC) #3
Ilya Sherman
On 2014/07/08 23:47:26, tkent wrote: > On 2014/07/08 23:02:47, Ilya Sherman wrote: > > It ...
6 years, 5 months ago (2014-07-08 23:51:41 UTC) #4
harpreet.sk
On 2014/07/08 23:51:41, Ilya Sherman wrote: > I see. Yes, I think the right solution ...
6 years, 5 months ago (2014-07-09 03:16:17 UTC) #5
Ilya Sherman
LGTM, thanks.
6 years, 5 months ago (2014-07-09 03:22:10 UTC) #6
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-09 03:22:14 UTC) #7
Ilya Sherman
The CQ bit was unchecked by isherman@chromium.org
6 years, 5 months ago (2014-07-09 03:22:49 UTC) #8
Ilya Sherman
Please note that I've updated the CL description.
6 years, 5 months ago (2014-07-09 03:25:30 UTC) #9
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-09 03:25:34 UTC) #10
Ilya Sherman
The CQ bit was unchecked by isherman@chromium.org
6 years, 5 months ago (2014-07-09 03:26:07 UTC) #11
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-09 03:26:07 UTC) #12
Ilya Sherman
The CQ bit was unchecked by isherman@chromium.org
6 years, 5 months ago (2014-07-09 03:26:31 UTC) #13
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-09 03:26:31 UTC) #14
harpreet.sk
On 2014/07/09 03:25:30, Ilya Sherman wrote: > Please note that I've updated the CL description. ...
6 years, 5 months ago (2014-07-09 03:27:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/373023004/20001
6 years, 5 months ago (2014-07-09 03:27:20 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 05:20:06 UTC) #17
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 06:17:50 UTC) #18
Message was sent while issue was closed.
Change committed as 281975

Powered by Google App Engine
This is Rietveld 408576698