Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: Source/core/xml/XMLHttpRequest.cpp

Issue 373023002: Un-deprecate XMLHttpRequest.send(ArrayBuffer) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/XMLHttpRequest.cpp
diff --git a/Source/core/xml/XMLHttpRequest.cpp b/Source/core/xml/XMLHttpRequest.cpp
index 2e7849e37cb1486404e8f2e1ff37d65b8530bafe..49360df6ac3a06fc6d5418237fa455856333a975 100644
--- a/Source/core/xml/XMLHttpRequest.cpp
+++ b/Source/core/xml/XMLHttpRequest.cpp
@@ -67,13 +67,6 @@ namespace WebCore {
DEFINE_DEBUG_ONLY_GLOBAL(WTF::RefCountedLeakCounter, xmlHttpRequestCounter, ("XMLHttpRequest"));
-// Histogram enum to see when we can deprecate xhr.send(ArrayBuffer).
-enum XMLHttpRequestSendArrayBufferOrView {
- XMLHttpRequestSendArrayBuffer,
- XMLHttpRequestSendArrayBufferView,
- XMLHttpRequestSendArrayBufferOrViewMax,
-};
-
struct XMLHttpRequestStaticData {
WTF_MAKE_NONCOPYABLE(XMLHttpRequestStaticData); WTF_MAKE_FAST_ALLOCATED;
public:
@@ -768,11 +761,6 @@ void XMLHttpRequest::send(ArrayBuffer* body, ExceptionState& exceptionState)
{
WTF_LOG(Network, "XMLHttpRequest %p send() ArrayBuffer %p", this, body);
- String consoleMessage("ArrayBuffer is deprecated in XMLHttpRequest.send(). Use ArrayBufferView instead.");
- executionContext()->addConsoleMessage(JSMessageSource, WarningMessageLevel, consoleMessage);
-
- blink::Platform::current()->histogramEnumeration("WebCore.XHR.send.ArrayBufferOrView", XMLHttpRequestSendArrayBuffer, XMLHttpRequestSendArrayBufferOrViewMax);
-
sendBytesData(body->data(), body->byteLength(), exceptionState);
}
@@ -780,8 +768,6 @@ void XMLHttpRequest::send(ArrayBufferView* body, ExceptionState& exceptionState)
{
WTF_LOG(Network, "XMLHttpRequest %p send() ArrayBufferView %p", this, body);
- blink::Platform::current()->histogramEnumeration("WebCore.XHR.send.ArrayBufferOrView", XMLHttpRequestSendArrayBufferView, XMLHttpRequestSendArrayBufferOrViewMax);
-
sendBytesData(body->baseAddress(), body->byteLength(), exceptionState);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698