Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Issue 373023002: Un-deprecate XMLHttpRequest.send(ArrayBuffer) (Closed)

Created:
6 years, 5 months ago by pwnall-personal
Modified:
6 years, 5 months ago
CC:
blink-reviews, tyoshino (SeeGerritForStatus)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Un-deprecate XMLHttpRequest.send(ArrayBuffer) Using an ArrayBuffer as the argument of send was un-deprecated in the latest WHATWG specification, according to https://www.w3.org/Bugs/Public/show_bug.cgi?id=26153#c1 BUG=237493 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178249

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M Source/core/xml/XMLHttpRequest.cpp View 1 4 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pwnall-personal
Kent-san, can you please take a look?
6 years, 5 months ago (2014-07-08 10:17:05 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm please wait a bit to see if opinions come up at the un-deprecate thread. ...
6 years, 5 months ago (2014-07-08 11:54:49 UTC) #2
pwnall-personal
https://codereview.chromium.org/373023002/diff/1/Source/core/xml/XMLHttpRequest.cpp File Source/core/xml/XMLHttpRequest.cpp (right): https://codereview.chromium.org/373023002/diff/1/Source/core/xml/XMLHttpRequest.cpp#newcode57 Source/core/xml/XMLHttpRequest.cpp:57: #include "public/platform/Platform.h" On 2014/07/08 11:54:48, tyoshino wrote: > remove ...
6 years, 5 months ago (2014-07-08 21:07:53 UTC) #3
pwnall-personal
On 2014/07/08 11:54:49, tyoshino wrote: > lgtm > > please wait a bit to see ...
6 years, 5 months ago (2014-07-16 06:07:05 UTC) #4
tkent
lgtm
6 years, 5 months ago (2014-07-16 06:12:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/costan@gmail.com/373023002/20001
6 years, 5 months ago (2014-07-16 06:12:39 UTC) #6
pwnall-personal
On 2014/07/16 06:12:10, tkent wrote: > lgtm Thank you for the quick response!
6 years, 5 months ago (2014-07-16 06:13:13 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 06:15:45 UTC) #8
Message was sent while issue was closed.
Change committed as 178249

Powered by Google App Engine
This is Rietveld 408576698