Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 373003005: Pepper: Small PnaclResources cleanup (Closed)

Created:
6 years, 5 months ago by teravest
Modified:
6 years, 5 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Pepper: Small PnaclResources cleanup This fixes a place where the wrong URL is used for the ld process when performing PNaCl translation. I don't believe the effect of this is severe, though it will cause the wrong url to be displayed when it's running. This also removes an unnecessary string constant usage in the trusted plugin. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282176

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M ppapi/api/private/ppb_nacl_private.idl View 1 chunk +1 line, -4 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 2 chunks +2 lines, -5 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_resources.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_resources.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
teravest
6 years, 5 months ago (2014-07-09 17:59:42 UTC) #1
dmichael (off chromium)
lgtm https://codereview.chromium.org/373003005/diff/20001/components/nacl/renderer/ppb_nacl_private_impl.cc File components/nacl/renderer/ppb_nacl_private_impl.cc (right): https://codereview.chromium.org/373003005/diff/20001/components/nacl/renderer/ppb_nacl_private_impl.cc#newcode1118 components/nacl/renderer/ppb_nacl_private_impl.cc:1118: static const char* kFilename = "chrome://pnacl-translator/pnacl.json"; nit: use ...
6 years, 5 months ago (2014-07-09 19:17:43 UTC) #2
teravest
On 2014/07/09 19:17:43, dmichael wrote: > lgtm > > https://codereview.chromium.org/373003005/diff/20001/components/nacl/renderer/ppb_nacl_private_impl.cc > File components/nacl/renderer/ppb_nacl_private_impl.cc (right): > ...
6 years, 5 months ago (2014-07-09 20:00:17 UTC) #3
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 5 months ago (2014-07-09 20:00:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/373003005/40001
6 years, 5 months ago (2014-07-09 20:02:39 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 23:39:24 UTC) #6
Message was sent while issue was closed. 
Change committed as 282176

Powered by Google App Engine
This is Rietveld 408576698