Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: src/store-buffer.cc

Issue 372983005: Make sure that the overflow store buffer size is always larger or equals than the regular store buf… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/store-buffer.cc
diff --git a/src/store-buffer.cc b/src/store-buffer.cc
index a7575ae32822344c7c626e81daa9a122a4e614f4..0e4fd6429bce7b7a103b907b9eebcfd712b1bf96 100644
--- a/src/store-buffer.cc
+++ b/src/store-buffer.cc
@@ -11,6 +11,7 @@
#include "src/base/atomicops.h"
#include "src/counters.h"
#include "src/store-buffer-inl.h"
+#include "src/utils.h"
namespace v8 {
namespace internal {
@@ -51,7 +52,9 @@ void StoreBuffer::SetUp() {
// The store buffer may reach this limit during a full garbage collection.
// Note that half of the semi-space should be good enough since half of the
// memory in the semi-space are not object pointers.
- old_store_buffer_length_ = heap_->MaxSemiSpaceSize() / sizeof(Address);
+ old_store_buffer_length_ =
+ Max(static_cast<int>(heap_->MaxSemiSpaceSize() / sizeof(Address)),
+ kOldRegularStoreBufferLength);
old_virtual_memory_ =
new base::VirtualMemory(old_store_buffer_length_ * kPointerSize);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698