Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 372983004: Remove obsolete make_file_array() uses from web/BUILD.gn (Closed)

Created:
6 years, 5 months ago by Jens Widell
Modified:
6 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove obsolete make_file_array() uses from web/BUILD.gn This is a simple follow-up to https://codereview.chromium.org/364323002/ removing from web/BUILD.gn what that CL removed from web.gyp. BUG=312586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177687

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M Source/web/BUILD.gn View 3 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jens Widell
PTAL Minor follow-up; forgot to update the GN build system in the previous CL.
6 years, 5 months ago (2014-07-08 11:07:36 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-08 15:40:46 UTC) #2
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-08 15:40:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/372983004/10001
6 years, 5 months ago (2014-07-08 15:41:59 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 19:57:07 UTC) #5
Message was sent while issue was closed.
Change committed as 177687

Powered by Google App Engine
This is Rietveld 408576698