Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 372963002: [fsp] Fix includes order in tests. (Closed)

Created:
6 years, 5 months ago by mtomasz
Modified:
6 years, 5 months ago
Reviewers:
hirono
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Fix includes order in tests. According to our style guide, in unit tests, the tested file's header should be first. TEST=Not related. Refactoring only. BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281684

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/close_file_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/get_metadata_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/unmount_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/service_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mtomasz
@hirono: PTAL at this tiny patch. Thanks!
6 years, 5 months ago (2014-07-08 05:34:34 UTC) #1
hirono
lgtm!
6 years, 5 months ago (2014-07-08 05:35:55 UTC) #2
mtomasz
The CQ bit was unchecked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-08 06:15:34 UTC) #3
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-08 06:15:34 UTC) #4
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-08 06:15:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/372963002/1
6 years, 5 months ago (2014-07-08 06:16:25 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 07:20:54 UTC) #7
Message was sent while issue was closed.
Change committed as 281684

Powered by Google App Engine
This is Rietveld 408576698