Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 372883002: Use 2x resources for 1.25 (Closed)

Created:
6 years, 5 months ago by oshima
Modified:
6 years, 5 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, rsesek+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : updated test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -25 lines) Patch
M ui/gfx/image/image_skia.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/image/image_skia_unittest.cc View 1 2 3 chunks +45 lines, -23 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
oshima
6 years, 5 months ago (2014-07-08 01:00:14 UTC) #1
Jun Mukai
lgtm but do we have already some specific cases this causes on Windows if we ...
6 years, 5 months ago (2014-07-08 01:31:22 UTC) #2
oshima
On 2014/07/08 01:31:22, Jun Mukai wrote: > lgtm but do we have already some specific ...
6 years, 5 months ago (2014-07-08 02:15:51 UTC) #3
oshima
We decided to use 2.0x resources for 1.25 on windows as well.
6 years, 5 months ago (2014-07-11 20:22:08 UTC) #4
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-11 20:22:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/372883002/10001
6 years, 5 months ago (2014-07-11 20:24:31 UTC) #6
oshima
The CQ bit was unchecked by oshima@chromium.org
6 years, 5 months ago (2014-07-11 22:21:45 UTC) #7
oshima
FYI: i had to update the test. let me know if you have any concern.
6 years, 5 months ago (2014-07-11 22:44:08 UTC) #8
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-11 22:44:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/372883002/80001
6 years, 5 months ago (2014-07-11 22:45:37 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 02:03:38 UTC) #11
Message was sent while issue was closed.
Change committed as 282777

Powered by Google App Engine
This is Rietveld 408576698