Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 372853003: Cut reference from MountedDiskMonitor to DiskMountManager. (Closed)

Created:
6 years, 5 months ago by kinaba
Modified:
6 years, 5 months ago
Reviewers:
hirono
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cut reference from MountedDiskMonitor to DiskMountManager. For number of reasons: * The previous code implicitly relied on the fact that the Observer events are notified to MountedDiskMonitor before VolumeManager (otherwise VolumeManager::OnDiskEvent misses the hard-unplug event.) It indeed holds, but it is not a part of explicit contract of base::ObserverList. We should not rely on the detail. * It simplifies MountedDiskMonitor (see the number of lines.) * It simplifies the initialization process of VolumeManager/DiskMountManager, i.e., removes duplicated RequestMountInfoRefresh calls. This is desired for Bug 356583. BUG=356583 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281920

Patch Set 1 #

Patch Set 2 : Test #

Patch Set 3 : Fix more test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -98 lines) Patch
M chrome/browser/chromeos/file_manager/mounted_disk_monitor.h View 2 chunks +11 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/file_manager/mounted_disk_monitor.cc View 3 chunks +3 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/file_manager/mounted_disk_monitor_unittest.cc View 1 6 chunks +26 lines, -40 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 5 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager_unittest.cc View 1 2 2 chunks +29 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
kinaba
6 years, 5 months ago (2014-07-08 08:14:33 UTC) #1
kinaba
On 2014/07/08 08:14:33, kinaba wrote: Oops I forgot to include the updated test in the ...
6 years, 5 months ago (2014-07-08 08:27:10 UTC) #2
hirono
lgtm!
6 years, 5 months ago (2014-07-08 08:54:56 UTC) #3
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 5 months ago (2014-07-08 08:56:18 UTC) #4
kinaba
The CQ bit was unchecked by kinaba@chromium.org
6 years, 5 months ago (2014-07-08 08:56:28 UTC) #5
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 5 months ago (2014-07-08 08:57:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/372853003/20001
6 years, 5 months ago (2014-07-08 08:58:14 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 10:28:25 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 11:32:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/45337)
6 years, 5 months ago (2014-07-08 11:32:02 UTC) #10
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 5 months ago (2014-07-09 00:28:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/372853003/40001
6 years, 5 months ago (2014-07-09 00:30:17 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 04:14:15 UTC) #13
Message was sent while issue was closed.
Change committed as 281920

Powered by Google App Engine
This is Rietveld 408576698