Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 372843007: [SyncFS] Implement getters and counters of FileMetadata and FileTracker (Closed)

Created:
6 years, 5 months ago by peria
Modified:
6 years, 5 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Implement following four methods. - CountFileMetadata - CountFileTracker - GetAllMeatadaIDs - GetAllTrackerIDs BUG=347425 TEST=./unit_tests --gtest_filter="Metadata*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281980

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Work for nit #

Patch Set 3 : Fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -12 lines) Patch
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc View 2 chunks +40 lines, -12 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc View 1 2 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
peria
PTL.
6 years, 5 months ago (2014-07-08 09:30:09 UTC) #1
tzik
lgtm
6 years, 5 months ago (2014-07-08 10:42:37 UTC) #2
peria
The CQ bit was checked by peria@chromium.org
6 years, 5 months ago (2014-07-09 01:40:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/372843007/20001
6 years, 5 months ago (2014-07-09 01:41:23 UTC) #4
nhiroki
LGTM with nits (you don't have to stop the CQ) https://codereview.chromium.org/372843007/diff/20001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc (right): https://codereview.chromium.org/372843007/diff/20001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc#newcode191 ...
6 years, 5 months ago (2014-07-09 02:13:45 UTC) #5
peria
The CQ bit was unchecked by peria@chromium.org
6 years, 5 months ago (2014-07-09 02:17:13 UTC) #6
peria
The CQ bit was checked by peria@chromium.org
6 years, 5 months ago (2014-07-09 02:18:36 UTC) #7
peria
https://codereview.chromium.org/372843007/diff/20001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc (right): https://codereview.chromium.org/372843007/diff/20001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc#newcode191 chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc:191: EXPECT_EQ(3U, file_ids.size()); On 2014/07/09 02:13:45, nhiroki wrote: > This ...
6 years, 5 months ago (2014-07-09 02:18:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/372843007/40001
6 years, 5 months ago (2014-07-09 02:21:06 UTC) #9
peria
The CQ bit was unchecked by peria@chromium.org
6 years, 5 months ago (2014-07-09 02:31:43 UTC) #10
peria
The CQ bit was checked by peria@chromium.org
6 years, 5 months ago (2014-07-09 02:33:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/372843007/60001
6 years, 5 months ago (2014-07-09 02:34:41 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 04:21:03 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 06:42:00 UTC) #14
Message was sent while issue was closed.
Change committed as 281980

Powered by Google App Engine
This is Rietveld 408576698