Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 372843006: Android: Exclude google drive code. (Closed)

Created:
6 years, 5 months ago by Lei Zhang
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -118 lines) Patch
M chrome/chrome_browser.gypi View 2 chunks +18 lines, -18 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +8 lines, -4 lines 0 comments Download
M google_apis/BUILD.gn View 1 5 chunks +53 lines, -47 lines 0 comments Download
M google_apis/google_apis.gyp View 7 chunks +54 lines, -49 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
6 years, 5 months ago (2014-07-08 07:42:52 UTC) #1
kinaba
lgtm as long as it compiles.
6 years, 5 months ago (2014-07-08 07:45:16 UTC) #2
Lei Zhang
+rogerta for top level google_apis/OWNERS. There's only 1 owner there. :\
6 years, 5 months ago (2014-07-08 07:48:56 UTC) #3
Lei Zhang
On 2014/07/08 07:48:56, Lei Zhang wrote: > +rogerta for top level google_apis/OWNERS. There's only 1 ...
6 years, 5 months ago (2014-07-09 08:40:03 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-09 08:40:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/372843006/20001
6 years, 5 months ago (2014-07-09 08:41:14 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 10:41:14 UTC) #7
Message was sent while issue was closed.
Change committed as 282001

Powered by Google App Engine
This is Rietveld 408576698