Issue 372843005: Remove Profile from BaseSearchProvider::NavigationResult

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 372843005: Remove Profile from BaseSearchProvider::NavigationResult (Closed)

Created:
6 years, 5 months ago by hashimoto

Modified:
6 years, 5 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, James Su, Jun Mukai

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove Profile from BaseSearchProvider::NavigationResult No need to call GetPrefs()->GetString(prefs::kAcceptLanguages) as all callers are passing the same value as |languages|. BUG=388515 TEST=build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281972

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -27 lines)			Patch
M	chrome/browser/autocomplete/base_search_provider.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/base_search_provider.cc	View	4 chunks	+8 lines, -16 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider_unittest.cc	View	4 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/zero_suggest_provider.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/372843005/1

6 years, 5 months ago (2014-07-09 01:59:54 UTC) #4

Message was sent while issue was closed.

Change committed as 281972

Expand Messages | Collapse Messages