Undefine _POSIX_C_SOURCE before redefining in third_party/harfbuzz-ng/src/hb-blob.cc (again).

Undefine _POSIX_C_SOURCE before redefining in third_party/harfbuzz-ng/src/hb-blob.cc (again).

BUG=391520
TBR=eae@chromium.org,jshin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281718

[Dai Mikurube (NOT FULLTIME), 2014-07-08 05:08:37]

Hi eae,

Sorry, I'm adding a local change in third_party/harfbuzz-ng which you rolled in
http://crrev.com/258137. It's the same fix as I did in http://crrev.com/191781.

Please tell me if it's unacceptable.

It's because this change broke memory profiling which run with an extended Clang
compiler in the following way:

1) The extended Clang inserts "#include <typeinfo>" at .cc's top.
2) /usr/include/features.h is included from <typeinfo>.
3) /usr/include/features.h defines _POSIX_C_SOURCE by itself.
4) The definitions conflict.

I'm not sure if we should upstream it, but in general, I think _POSIX_C_SOURCE
should be defined with checking pre-definitions.

[Dai Mikurube (NOT FULLTIME), 2014-07-08 05:08:50]

The CQ bit was checked by dmikurube@chromium.org

[commit-bot: I haz the power, 2014-07-08 05:10:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmikurube@chromium.org/372843004/1

[Dai Mikurube (NOT FULLTIME), 2014-07-08 07:39:56]

Adding jshin@ as a TBR reviewer. Please take a look at the previous comments.

[commit-bot: I haz the power, 2014-07-08 09:51:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-08 11:23:29]

Change committed as 281718

[eae, 2014-07-08 15:18:18]

This should either be upstreamed or added as a patch in third_party/harfbuzz-ng
and indicated in the README.chromium file.

If not this will break every time we update harfbuzz (a couple of times a year).

Also, please do not TBR changes you're not sure about.

[Dai Mikurube (NOT FULLTIME), 2014-07-09 03:33:48]

It has already been in README.chromium for a long time and it was removed by
http://crrev.com/258137. I committed it as TBR since I thought it's a breakage.
Sorry about that.

Okay, I'll add a patch file on third_party/harfbuzz-ng. Do you have any manners
about such a patch? (For example, a name of the patch file, the top directory of
the patch file (where to run diff), and formats in README.chromium.)

[eae, 2014-07-09 05:31:10]

On 2014/07/09 03:33:48, Dai Mikurube wrote:
> It has already been in README.chromium for a long time and it was removed by
> http://crrev.com/258137. I committed it as TBR since I thought it's a
breakage.
> Sorry about that.
> 
> Okay, I'll add a patch file on third_party/harfbuzz-ng. Do you have any
manners
> about such a patch? (For example, a name of the patch file, the top directory
of
> the patch file (where to run diff), and formats in README.chromium.)

I'd prefer it if you posted a patch for behdad to integrate into the upstream
repro, failing that any .diff/.patch file in the harfuzz-ng/ directory will do.
Thank you!

[Dai Mikurube (NOT FULLTIME), 2014-07-09 06:23:58]

On 2014/07/09 05:31:10, eae wrote:
> On 2014/07/09 03:33:48, Dai Mikurube wrote:
> > It has already been in README.chromium for a long time and it was removed by
> > http://crrev.com/258137. I committed it as TBR since I thought it's a
> breakage.
> > Sorry about that.
> > 
> > Okay, I'll add a patch file on third_party/harfbuzz-ng. Do you have any
> manners
> > about such a patch? (For example, a name of the patch file, the top
directory
> of
> > the patch file (where to run diff), and formats in README.chromium.)
> 
> I'd prefer it if you posted a patch for behdad to integrate into the upstream
> repro, failing that any .diff/.patch file in the harfuzz-ng/ directory will
do.
> Thank you!

Sure! I just posted a pull request in a more general form.

[Dai Mikurube (NOT FULLTIME), 2014-07-10 04:13:11]

A similar patch is landed in the upstream.

http://cgit.freedesktop.org/harfbuzz/commit/src?id=73f7f8919ea1f09b8c5b29f231...