LayoutTests/fast/forms/form-request-autocomplete.html - Issue 37283002: Drop NotEnumerable for the on* event handler IDL attributes (again)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/forms/form-request-autocomplete.html

Issue 37283002: Drop NotEnumerable for the on* event handler IDL attributes (again) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rm redundant test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/window-event-handlers-expected.txt ('k') | LayoutTests/fast/forms/form-request-autocomplete-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/forms/form-request-autocomplete.html

diff --git a/LayoutTests/fast/forms/form-request-autocomplete.html b/LayoutTests/fast/forms/form-request-autocomplete.html

index 815603b6e06b060b4f0532ce622d914cf49a212f..705b5aacb195e1c3d702557e58b67c9b57dc199d 100644

--- a/LayoutTests/fast/forms/form-request-autocomplete.html

+++ b/LayoutTests/fast/forms/form-request-autocomplete.html

@@ -23,16 +23,14 @@ function runTests()

function checkForEnumerableProperties(form)

{

- var enumerated = false;

- for (var field in form) {

- if (/^onautocomplete/i.test(field))

- testFailed('enumerable form attribute found on HTMLFormElement: ' + field);

- enumerated = true;

- }

- if (enumerated)

- testPassed('no enumerable properties on HTMLFormElement');

- else

- testFailed('failed to enumerate HTMLFormElement properties');

+ var enumerable = {};

+ for (var field in form)

+ enumerable[field] = true;

+ if (!enumerable.onautocomplete)

+ testFailed('failed to enumerate HTMLFormElement.onautocomplete');

+ if (!enumerable.onautocompleteerror)

+ testFailed('failed to enumerate HTMLFormElement.onautocompleteerror');

+ testPassed('found enumerable properties on HTMLFormElement');

}

function checkDynamicAttributes()